Skip to content

Update prowbazel in proxy/master and proxy/wasm to 0.5.8.#1494

Merged
istio-testing merged 2 commits intoistio:masterfrom
PiotrSikora:prowbazel_0.5.8
Jul 17, 2019
Merged

Update prowbazel in proxy/master and proxy/wasm to 0.5.8.#1494
istio-testing merged 2 commits intoistio:masterfrom
PiotrSikora:prowbazel_0.5.8

Conversation

@PiotrSikora
Copy link
Copy Markdown
Contributor

Signed-off-by: Piotr Sikora piotrsikora@google.com

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 17, 2019
@istio-testing istio-testing requested review from fejta and utka July 17, 2019 03:45
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

Blocked on #1493.

@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 17, 2019
Copy link
Copy Markdown
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@@ -1,5 +1,5 @@
PROJECT = istio-testing
VERSION ?= 0.5.7
VERSION ?= 0.5.8
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a patch update?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wouldn't it be? (genuine question) There doesn't seem to be any pattern for minor and patch updates, as far as I can tell. See: docker/prowbazel/README.md.

Having said that, I've now noticed that this file should be updated in #1493, since image recipes are updated there and not this PR. Let me fix that.

@istio-testing istio-testing added do-not-merge/hold Block automatic merging of a PR. lgtm labels Jul 17, 2019
@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, PiotrSikora

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@utka
Copy link
Copy Markdown
Contributor

utka commented Jul 17, 2019

/lgtm

@Katharine
Copy link
Copy Markdown
Member

This image now exists so this is mergeable, but I don't think I'll be able to unhold. Let's try it anyway…

/hold cancel

@istio-testing istio-testing removed the do-not-merge/hold Block automatic merging of a PR. label Jul 17, 2019
@istio-testing istio-testing merged commit cfd6f91 into istio:master Jul 17, 2019
@istio-testing
Copy link
Copy Markdown
Collaborator

@PiotrSikora: Updated the job-config configmap in namespace default using the following files:

  • key istio.proxy.master.yaml using file prow/cluster/jobs/istio/proxy/istio.proxy.master.yaml
  • key istio.proxy.wasm.yaml using file prow/cluster/jobs/istio/proxy/istio.proxy.wasm.yaml
Details

In response to this:

Signed-off-by: Piotr Sikora piotrsikora@google.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants