Skip to content

Update Bazel to 0.28.0.#1493

Merged
istio-testing merged 2 commits intoistio:masterfrom
PiotrSikora:bazel_0.28
Jul 17, 2019
Merged

Update Bazel to 0.28.0.#1493
istio-testing merged 2 commits intoistio:masterfrom
PiotrSikora:bazel_0.28

Conversation

@PiotrSikora
Copy link
Copy Markdown
Contributor

@PiotrSikora PiotrSikora commented Jul 17, 2019

Signed-off-by: Piotr Sikora piotrsikora@google.com

@PiotrSikora
Update Bazel to 0.28.0.
7d2596c 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 17, 2019
@istio-testing istio-testing requested review from fejta and utka July 17, 2019 03:45
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 17, 2019
This was referenced Jul 17, 2019
Merged
Merged
fejta
fejta approved these changes Jul 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
What produces the images?
Do a /hold cancel when you're ready for it to merge

@istio-testing istio-testing added the do-not-merge/hold Block automatic merging of a PR. label Jul 17, 2019
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, PiotrSikora

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PiotrSikora
review: bump VERSION.
1687385 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora added a commit to PiotrSikora/test-infra that referenced this pull request Jul 17, 2019
@PiotrSikora
review: don't change VERSION here (do it in istio#1493 instead).
44f6373 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

PiotrSikora commented Jul 17, 2019

No idea who/what produces the images. I believe it's a manual step, but I don't have permissions to push the images, so I don't have the details. cc @utka

@utka
Copy link
Copy Markdown
Contributor

utka commented Jul 17, 2019

/lgtm
I lost permissions to push images as well. I think it can be done by prow on call

@PiotrSikora
Copy link
Copy Markdown
Contributor Author

PiotrSikora commented Jul 17, 2019

So we should cancel the hold and once it's merged we should get prow on-call to build & push the image? I that correct?

@utka
Copy link
Copy Markdown
Contributor

utka commented Jul 17, 2019

This is my understanding how prow on call works

@PiotrSikora
Copy link
Copy Markdown
Contributor Author

PiotrSikora commented Jul 17, 2019

/hold cancel

@istio-testing istio-testing removed the do-not-merge/hold Block automatic merging of a PR. label Jul 17, 2019
@istio-testing istio-testing merged commit c93b5c9 into istio:master Jul 17, 2019
@Katharine
Copy link
Copy Markdown
Member

Katharine commented Jul 17, 2019

I've built and pushed the image.

@fejta
Copy link
Copy Markdown
Contributor

fejta commented Jul 17, 2019

This isn't really a prow service. I suspect But we should have access to the istio-testing... and while I'm writing this looks like Katharine already did it (thanks!). I suspect she did this by running a command on her workstation (hence why it isn't prow).

Ideally we create postsubmits to build and push these images, like we do for kubernets/test-infra images. Then we can make sure prow is running those correctly. Examples of these jobs:

istio-testing pushed a commit that referenced this pull request Jul 17, 2019
@PiotrSikora @istio-testing
Update prowbazel in proxy/master and proxy/wasm to 0.5.8. (#1494)
cfd6f91 
* Update prowbazel in proxy/master and proxy/wasm to 0.5.8.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

* review: don't change VERSION here (do it in #1493 instead).

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@utka utka Awaiting requested review from utka

1 more reviewer

@fejta fejta fejta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fejta fejta

@utka utka

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@PiotrSikora @istio-testing @utka @Katharine @fejta @googlebot