Skip to content

Support multiple versions of the Proxy-Wasm ABI.#248

Merged
istio-testing merged 3 commits intoistio:release-1.7from
PiotrSikora:dual_abi-istio-1.7
Aug 4, 2020
Merged

Support multiple versions of the Proxy-Wasm ABI.#248
istio-testing merged 3 commits intoistio:release-1.7from
PiotrSikora:dual_abi-istio-1.7

Conversation

@PiotrSikora
Copy link

Signed-off-by: Piotr Sikora piotrsikora@google.com

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@istio-testing
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@PiotrSikora
Copy link
Author

/test all

@PiotrSikora
Copy link
Author

/test test-tsan_envoy_release-1.7

@PiotrSikora PiotrSikora marked this pull request as ready for review August 3, 2020 01:28
@PiotrSikora PiotrSikora requested a review from jplevyak August 3, 2020 01:28
Copy link
Author

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a backport of envoyproxy/envoy-wasm#596, please do not merge until it's merged.

/wait

urls = ["https://github.com/proxy-wasm/proxy-wasm-cpp-host/archive/646d814b32692e2c40a8bd97cd3a100fb97dfb26.tar.gz"],
sha256 = "00a4aee4982cbf6c48ccc16c6c579ca3b73c49354fa1824d24bcc9d9193c445b",
strip_prefix = "proxy-wasm-cpp-host-27d078d4a6634e906779b0a2d68e19ce9d78c36a",
urls = ["https://github.com/proxy-wasm/proxy-wasm-cpp-host/archive/27d078d4a6634e906779b0a2d68e19ce9d78c36a.tar.gz"],
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: This needs to be updated once proxy-wasm/proxy-wasm-cpp-host#45 is merged.

urls = ["https://github.com/proxy-wasm/proxy-wasm-cpp-sdk/archive/4ee6ace4fe529b9fdbffa76f34eb6deffe72c1a2.tar.gz"],
sha256 = "ad8e721a46ffdab582a1cec0d7280b95ea04991146a7eb7d75c0596a451d7b09",
strip_prefix = "proxy-wasm-cpp-sdk-75607eaad4dbe8191e47a62fdfb1e05a3a2cedce",
urls = ["https://github.com/PiotrSikora/proxy-wasm-cpp-sdk/archive/75607eaad4dbe8191e47a62fdfb1e05a3a2cedce.tar.gz"],
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: This needs to be updated once proxy-wasm/proxy-wasm-cpp-sdk#42 is merged.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora PiotrSikora changed the title Support both: 0.1.0 and 0.2.0 versions of the Proxy-Wasm ABI. Support multiple versions of the Proxy-Wasm ABI. Aug 4, 2020
@PiotrSikora
Copy link
Author

/test test-tsan_envoy_release-1.7

2 similar comments
@PiotrSikora
Copy link
Author

/test test-tsan_envoy_release-1.7

@PiotrSikora
Copy link
Author

/test test-tsan_envoy_release-1.7

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora
Copy link
Author

/test test-tsan_envoy_release-1.7

@istio-testing istio-testing merged commit 5f126df into istio:release-1.7 Aug 4, 2020
istio-testing pushed a commit that referenced this pull request Apr 20, 2021
* http: Fixing empty metadata map handling (#230) (#248)

Commit Message: Fixing a crash when the decoder receives an empty metadata map.

Additional Description:
Upon receiving an empty metadata map and trying to decode it an assertion is triggered in debug mode, and a seg-fault occurs in release mode.
The proposed fix ignores the empty metadata maps and updates a stats if one is received.

Risk Level: Medium for Envoy's running with Metadata support.
Testing: Added integration tests.
Docs Changes: Added a codec stats counter description.
Release Notes: Added bug fix description.
Platform Specific Features: N/A.
Fixes a fuzz bug: 25303

Signed-off-by: Adi Suissa-Peleg <adip@google.com>

Co-authored-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>

* backport 1.14: grpc: fix grpc-timeout integer-overflow (#257)

Fixes CVE-2021-28682, a remotely exploitable integer overflow.

Signed-off-by: Asra Ali <asraa@google.com>
Co-authored-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>

* v1.14.7 release

Signed-off-by: Tony Allen <tony@allen.gg>

Co-authored-by: Adi (Suissa) Peleg <adip@google.com>
Co-authored-by: Tony Allen <tony@allen.gg>
Co-authored-by: Rei Shimizu <Shikugawa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants