Skip to content

Merge envoyproxy/envoy release/v1.14.7 tag#318

Merged
istio-testing merged 4 commits intoistio:release-1.6from
jacob-delgado:merge-in-v147-tag
Apr 20, 2021
Merged

Merge envoyproxy/envoy release/v1.14.7 tag#318
istio-testing merged 4 commits intoistio:release-1.6from
jacob-delgado:merge-in-v147-tag

Conversation

@jacob-delgado
Copy link

Merge envoyproxy/envoy release/v1.14.7 tag

adisuissa and others added 4 commits April 14, 2021 21:14
Commit Message: Fixing a crash when the decoder receives an empty metadata map.

Additional Description:
Upon receiving an empty metadata map and trying to decode it an assertion is triggered in debug mode, and a seg-fault occurs in release mode.
The proposed fix ignores the empty metadata maps and updates a stats if one is received.

Risk Level: Medium for Envoy's running with Metadata support.
Testing: Added integration tests.
Docs Changes: Added a codec stats counter description.
Release Notes: Added bug fix description.
Platform Specific Features: N/A.
Fixes a fuzz bug: 25303

Signed-off-by: Adi Suissa-Peleg <adip@google.com>

Co-authored-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Fixes CVE-2021-28682, a remotely exploitable integer overflow.

Signed-off-by: Asra Ali <asraa@google.com>
Co-authored-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
@google-cla
Copy link

google-cla bot commented Apr 19, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@jacob-delgado jacob-delgado changed the title http: Fixing empty metadata map handling (#230) (#248) Merge envoyproxy/envoy release/v1.14.7 tag Apr 20, 2021
@Monkeyanator
Copy link

/retest

@istio-testing istio-testing merged commit 976971f into istio:release-1.6 Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants