Skip to content
This repository was archived by the owner on Dec 16, 2020. It is now read-only.

Support multiple versions of the Proxy-Wasm ABI.#596

Merged
PiotrSikora merged 5 commits intoenvoyproxy:masterfrom
PiotrSikora:dual_abi
Aug 4, 2020
Merged

Support multiple versions of the Proxy-Wasm ABI.#596
PiotrSikora merged 5 commits intoenvoyproxy:masterfrom
PiotrSikora:dual_abi

Conversation

@PiotrSikora
Copy link
Contributor

Signed-off-by: Piotr Sikora piotrsikora@google.com

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora PiotrSikora marked this pull request as ready for review August 2, 2020 14:17
@PiotrSikora
Copy link
Contributor Author

(Note: asan integration tests with external repositories are broken on master)

@jplevyak
Copy link
Contributor

jplevyak commented Aug 3, 2020

I would have expected a switch somewhere, although perhaps we don't have any incompatible changes at this point. If that is the case, please add a comment in the appropriate place (e.g. the docs or where the version functions are registered).

@PiotrSikora
Copy link
Contributor Author

I would have expected a switch somewhere, although perhaps we don't have any incompatible changes at this point. If that is the case, please add a comment in the appropriate place (e.g. the docs or where the version functions are registered).

All the switching is happening in Proxy-Wasm C++ Host implementation (see: proxy-wasm/proxy-wasm-cpp-host#42).

Note, that because we register/expose host functions before linking, we don't know the exported ABI version marker at that point, so we expose host functions for both 0.1.0 and 0.2.0 version of the ABI (since they are not conflicting), and the switching is only happening for the callbacks.

We could expose host functions only for the requested ABI version, but that would require some invasive rewrites to the code that I'm not willing to make just before the release.

…l_abi

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora PiotrSikora changed the title Support both: 0.1.0 and 0.2.0 versions of the Proxy-Wasm ABI. Support multiple versions of the Proxy-Wasm ABI. Aug 4, 2020
@PiotrSikora PiotrSikora merged commit a9dabc9 into envoyproxy:master Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants