Support multiple versions of the Proxy-Wasm ABI.#45
Merged
PiotrSikora merged 4 commits intoproxy-wasm:envoy-release/v1.15from Aug 4, 2020
Merged
Conversation
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
jplevyak
reviewed
Aug 3, 2020
src/wasm.cc
Outdated
| _REGISTER_PROXY(set_property); | ||
| _REGISTER_PROXY(get_property); | ||
|
|
||
| _REGISTER_PROXY(continue_request); |
Contributor
There was a problem hiding this comment.
Shouldn't these be conditional based on the version?
Member
Author
There was a problem hiding this comment.
See envoyproxy/envoy-wasm#596 (comment):
Note, that because we register/expose host functions before linking, we don't know the exported ABI version marker at that point, so we expose host functions for both 0.1.0 and 0.2.0 version of the ABI (since they are not conflicting), and the switching is only happening for the callbacks.
We could expose host functions only for the requested ABI version, but that would require some invasive rewrites to the code that I'm not willing to make just before the release.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
changed the title
jplevyak
approved these changes
Aug 4, 2020
PiotrSikora
added a commit
to PiotrSikora/proxy-wasm-cpp-host
that referenced
this pull request
Aug 10, 2020
Broken in proxy-wasm#45. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Merged
PiotrSikora
added a commit
that referenced
this pull request
Aug 10, 2020
Broken in #45. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Sikora piotrsikora@google.com