[release-1.28] test: Modify await_operator to dinamically get deployment name from csv when OLM is true#1878
Merged
istio-testing merged 2 commits intoApr 24, 2026
Conversation
…sv when OLM is true If bundle name is different to sail operator and OLM is set to true in the test we got failures because await_operator never find a sail-operator deployment in the namespace Signed-off-by: Francisco Herrera <fjglira@gmail.com>
… in the manifest/bundle folder Changes from review Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Merged
6 tasks
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## release-1.28 #1878 +/- ##
=================================================
- Coverage 79.39% 53.42% -25.98%
=================================================
Files 46 46
Lines 2966 2364 -602
=================================================
- Hits 2355 1263 -1092
- Misses 492 1018 +526
+ Partials 119 83 -36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fjglira
approved these changes
Apr 24, 2026
istio-testing
merged commit 2897f0e
into
istio-ecosystem:release-1.28
17 of 19 checks passed
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 24, 2026
* upstream/release-1.28: [release-1.28] test: Modify await_operator to dinamically get deployment name from csv when OLM is true (istio-ecosystem#1878)
unsortedhashsets
pushed a commit
to unsortedhashsets/sail-operator
that referenced
this pull request
May 26, 2026
…ent name from csv when OLM is true (istio-ecosystem#1878) * test: Modify await_operator to dinamically get deployment name from csv when OLM is true If bundle name is different to sail operator and OLM is set to true in the test we got failures because await_operator never find a sail-operator deployment in the namespace Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Get the deployment name from current .clusterserviceversion.yaml file in the manifest/bundle folder Changes from review Signed-off-by: Francisco Herrera <fjglira@gmail.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com> Co-authored-by: Francisco Herrera <fjglira@gmail.com>
openshift-merge-bot Bot
pushed a commit
to openshift-service-mesh/sail-operator
that referenced
this pull request
May 28, 2026
* OSSM 3.4 product changes - Makefile.vendor.mk - ossm/merge_upstream.sh - ossm/values.yaml - pkg/istioversion/versions.ossm.yaml - `make gen` output * e2e Test for Integration OSSM and Cert Manager in Sail Operator * Set empty vendor defaults for integration tests Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Increase mem limit of sail operator (#433) Upstream change for a reference - istio-ecosystem#1104 * Add istioctl consoleclidownload (#130) * Add istioctl consoleclidownload and install instructions Signed-off-by: bmangoen <bmangoen@redhat.com> * Modify the download URL Signed-off-by: bmangoen <bmangoen@redhat.com> * Fill supported commands table Signed-off-by: bmangoen <bmangoen@redhat.com> * Fix install procedure Signed-off-by: bmangoen <bmangoen@redhat.com> * Remove istioctl install doc Signed-off-by: bmangoen <bmangoen@redhat.com> * Add explanation for consoleclidownload Signed-off-by: bmangoen <bmangoen@redhat.com> --------- Signed-off-by: bmangoen <bmangoen@redhat.com> * Fix cert manager test Cert manager test is not available upstream so we need to apply changes to common funtions manually. * Removing workaround for OCPBUGS-56758 (#485) The bug is fixed, the workaround is no longer needed * Do not remove servicemeshoperator3.clusterserviceversion.yaml when (#757) (#758) merging upstream changes. We can't remove servicemeshoperator3.clusterserviceversion.yaml as it's embedded in bundle/bundle.go and mirror-licenses make target fails if it's missing Breaking change was introduced in #721 Signed-off-by: Filip Brychta <fbrychta@redhat.com> * Fix 3.4 operator manifest * Add istio v1.30-latest and 1.30.0 * Add 1.28.7 istio version and resources * Update vendor_defaults for 3.4 release * Remove gateway API workaround from Istio 1.28.4+ and 1.27.8+ * Restore EnsureNamespace function Restore EnsureNamespace function. The function was removed in 9fba17d but is needed by TLS adherence tests added in 1b879c5. * Add v1.26 EOL versions to maintain API compatibility Add v1.26.* as EOL entries in versions.ossm.yaml to prevent breaking changes from OSSM 3.3. These versions remain valid enum values but are not installable, following upstream pattern. Regenerate CRDs to pass schema compatibility validation. * tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) * tests: Skip TLS profile change test when is executed on Hosted clusters There are failures when the test is executed on hosted cluster because by default changing the TLS profile Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Adding comment Adding comment to let folks to know the reason of the skip Signed-off-by: Francisco Herrera <fjglira@gmail.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com> * enable cert-manager test when ambient mode is enabled * Run cert-manager test with ambient mode enabled (#660) * cert-manager operator removal process improvements * [release-1.28] test: Modify await_operator to dinamically get deployment name from csv when OLM is true (istio-ecosystem#1878) * test: Modify await_operator to dinamically get deployment name from csv when OLM is true If bundle name is different to sail operator and OLM is set to true in the test we got failures because await_operator never find a sail-operator deployment in the namespace Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Get the deployment name from current .clusterserviceversion.yaml file in the manifest/bundle folder Changes from review Signed-off-by: Francisco Herrera <fjglira@gmail.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com> Co-authored-by: Francisco Herrera <fjglira@gmail.com> * Set DEPLOYMENT_NAME to csv name when OLM is true (istio-ecosystem#1922) This will avoid issues on the test while waiting for operator because will set DEPLOYMENT_NAME to the csv name used into fork test Signed-off-by: Francisco Herrera <fjglira@gmail.com> Co-authored-by: Francisco Herrera <fjglira@gmail.com> * tests: Skip flaky TLS adherence test causing OOM The 'syncs TLS settings when TLSAdherence is set to StrictAllComponents' test causes OOM due to multiple operator restarts triggered by APIServer updates. Additionally, the test has nil pointer panics when accessing rev.Spec.Values.Pilot.ExtraContainerArgs on line 380. Skipping until the test is stabilized with proper timeouts and nil checks. --------- Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> Signed-off-by: Filip Brychta <fbrychta@redhat.com> Signed-off-by: Francisco Herrera <fjglira@gmail.com> Co-authored-by: ctartici <ctartici@redhat.com> Co-authored-by: Daniel Grimm <dgrimm@redhat.com> Co-authored-by: Filip Brychta <fbrychta@redhat.com> Co-authored-by: Brian Mangoenpawiro <bmangoen@gmail.com> Co-authored-by: Francisco Herrera <fjglira@gmail.com> Co-authored-by: Istio Automation <istio-testing-bot@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1874