test: Modify await_operator to dinamically get deployment name from csv when OLM is true#1874
Conversation
…sv when OLM is true If bundle name is different to sail operator and OLM is set to true in the test we got failures because await_operator never find a sail-operator deployment in the namespace Signed-off-by: Francisco Herrera <fjglira@gmail.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the e2e operator integration suite to correctly await the operator Deployment when running in OLM mode by deriving the Deployment name from the installed CSV instead of assuming a fixed deployment name.
Changes:
- Switch
await_operatorto resolve the operator Deployment name from the CSV whenOLM=true - Improve logging to reflect that the awaited deployment may vary in OLM mode
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1874 +/- ##
==========================================
+ Coverage 73.88% 80.48% +6.60%
==========================================
Files 51 51
Lines 3224 2598 -626
==========================================
- Hits 2382 2091 -291
+ Misses 719 383 -336
- Partials 123 124 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FilipB
left a comment
There was a problem hiding this comment.
Maybe it would be easier to parse the ClusterServiceVersion file directly in the repo instead of getting it dynamically from the cluster? There might be other CSV which will break this approach
… in the manifest/bundle folder Changes from review Signed-off-by: Francisco Herrera <fjglira@gmail.com>
|
/retest |
Did some change to get the name from the file in the bundle folder |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
In response to a cherrypick label: new pull request created: #1877 |
|
In response to a cherrypick label: new pull request created: #1878 |
|
In response to a cherrypick label: new pull request created: #1879 |
|
In response to a cherrypick label: #1874 failed to apply on top of branch "release-1.0": |
|
In response to a cherrypick label: new issue created for failed cherrypick: #1880 |
|
In response to a cherrypick label: new pull request created: #1881 |
* upstream/main: (35 commits) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1886) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1884) Fixing two problems with our hack/update-istio.sh script (istio-ecosystem#1882) test: Modify await_operator to dinamically get deployment name from csv when OLM is true (istio-ecosystem#1874) Update update-deps flow with 1.30 and remove 1.27 branch (istio-ecosystem#1875) tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) Add 1.30.0-alpha.2 charts (istio-ecosystem#1854) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1872) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) Add operator `TLSConfig` and sync with APIServer TLS profile on openshift (istio-ecosystem#1513) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1851) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1850) Add documentation for resource customization (istio-ecosystem#1292) refactor error and status condition handling (istio-ecosystem#1807) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1848) ...
* upstream/main: (39 commits) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1896) Fix test docs test failure (istio-ecosystem#1890) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1892) Skip processing aliases referencing pre-released versions in EOL updater (istio-ecosystem#1883) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1886) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1884) Fixing two problems with our hack/update-istio.sh script (istio-ecosystem#1882) test: Modify await_operator to dinamically get deployment name from csv when OLM is true (istio-ecosystem#1874) Update update-deps flow with 1.30 and remove 1.27 branch (istio-ecosystem#1875) tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) Add 1.30.0-alpha.2 charts (istio-ecosystem#1854) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1872) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) Add operator `TLSConfig` and sync with APIServer TLS profile on openshift (istio-ecosystem#1513) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1851) ...
* upstream/main: (41 commits) fix: handle repos with different release branch naming in crd-schema-checker (istio-ecosystem#1897) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1899) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1896) Fix test docs test failure (istio-ecosystem#1890) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1892) Skip processing aliases referencing pre-released versions in EOL updater (istio-ecosystem#1883) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1886) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1884) Fixing two problems with our hack/update-istio.sh script (istio-ecosystem#1882) test: Modify await_operator to dinamically get deployment name from csv when OLM is true (istio-ecosystem#1874) Update update-deps flow with 1.30 and remove 1.27 branch (istio-ecosystem#1875) tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) Add 1.30.0-alpha.2 charts (istio-ecosystem#1854) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1872) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) ...
* upstream/main: (41 commits) fix: handle repos with different release branch naming in crd-schema-checker (istio-ecosystem#1897) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1899) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1896) Fix test docs test failure (istio-ecosystem#1890) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1892) Skip processing aliases referencing pre-released versions in EOL updater (istio-ecosystem#1883) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1886) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1884) Fixing two problems with our hack/update-istio.sh script (istio-ecosystem#1882) test: Modify await_operator to dinamically get deployment name from csv when OLM is true (istio-ecosystem#1874) Update update-deps flow with 1.30 and remove 1.27 branch (istio-ecosystem#1875) tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) Add 1.30.0-alpha.2 charts (istio-ecosystem#1854) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1872) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) ...
* test: Modify await_operator to dinamically get deployment name from csv when OLM is true (#1874) * test: Modify await_operator to dinamically get deployment name from csv when OLM is true If bundle name is different to sail operator and OLM is set to true in the test we got failures because await_operator never find a sail-operator deployment in the namespace Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Get the deployment name from current .clusterserviceversion.yaml file in the manifest/bundle folder Changes from review Signed-off-by: Francisco Herrera <fjglira@gmail.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Set DEPLOYMENT_NAME to csv name when OLM is true (#1918) This will avoid issues on the test while waiting for operator because will set DEPLOYMENT_NAME to the csv name used into fork test Signed-off-by: Francisco Herrera <fjglira@gmail.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com>
If the bundle name is different from the sail operator, and OLM is set to true in the test, we got failures because await_operator never finds a sail-operator deployment in the namespace
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Related Issue/PR #
Additional information: