[release-1.28] Set DEPLOYMENT_NAME to csv name when OLM is true#1922
Merged
istio-testing merged 1 commit intoMay 8, 2026
Conversation
This will avoid issues on the test while waiting for operator because will set DEPLOYMENT_NAME to the csv name used into fork test Signed-off-by: Francisco Herrera <fjglira@gmail.com>
6 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.28 #1922 +/- ##
=============================================
Coverage 80.32% 80.32%
=============================================
Files 46 46
Lines 2364 2364
=============================================
Hits 1899 1899
Misses 343 343
Partials 122 122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fjglira
approved these changes
May 8, 2026
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
May 8, 2026
* upstream/release-1.28: Set DEPLOYMENT_NAME to csv name when OLM is true (istio-ecosystem#1922)
unsortedhashsets
pushed a commit
to unsortedhashsets/sail-operator
that referenced
this pull request
May 26, 2026
This will avoid issues on the test while waiting for operator because will set DEPLOYMENT_NAME to the csv name used into fork test Signed-off-by: Francisco Herrera <fjglira@gmail.com> Co-authored-by: Francisco Herrera <fjglira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1918