tests: Skip TLS profile change test when is executed on Hosted clusters#1873
Merged
Conversation
There are failures when the test is executed on hosted cluster because by default changing the TLS profile Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Adding comment to let folks to know the reason of the skip Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Contributor
Author
|
THe test was just added on main, so we are not going to cherry-pick this change |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #1873 +/- ##
===========================================
- Coverage 73.88% 51.20% -22.68%
===========================================
Files 51 51
Lines 3224 3224
===========================================
- Hits 2382 1651 -731
- Misses 719 1488 +769
+ Partials 123 85 -38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mkralik3
approved these changes
Apr 23, 2026
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 24, 2026
* upstream/main: (31 commits) Update update-deps flow with 1.30 and remove 1.27 branch (istio-ecosystem#1875) tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) Add 1.30.0-alpha.2 charts (istio-ecosystem#1854) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1872) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) Add operator `TLSConfig` and sync with APIServer TLS profile on openshift (istio-ecosystem#1513) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1851) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1850) Add documentation for resource customization (istio-ecosystem#1292) refactor error and status condition handling (istio-ecosystem#1807) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1848) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1845) feat: add targetRef field to ZTunnel CRD (istio-ecosystem#1259) Add 1.29.2 and 1.28.6 versions (istio-ecosystem#1844) Use typed Go structs for FIPS values instead of helm.Values (istio-ecosystem#1695) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 27, 2026
* upstream/main: (35 commits) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1886) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1884) Fixing two problems with our hack/update-istio.sh script (istio-ecosystem#1882) test: Modify await_operator to dinamically get deployment name from csv when OLM is true (istio-ecosystem#1874) Update update-deps flow with 1.30 and remove 1.27 branch (istio-ecosystem#1875) tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) Add 1.30.0-alpha.2 charts (istio-ecosystem#1854) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1872) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) Add operator `TLSConfig` and sync with APIServer TLS profile on openshift (istio-ecosystem#1513) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1851) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1850) Add documentation for resource customization (istio-ecosystem#1292) refactor error and status condition handling (istio-ecosystem#1807) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1848) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 30, 2026
* upstream/main: (39 commits) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1896) Fix test docs test failure (istio-ecosystem#1890) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1892) Skip processing aliases referencing pre-released versions in EOL updater (istio-ecosystem#1883) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1886) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1884) Fixing two problems with our hack/update-istio.sh script (istio-ecosystem#1882) test: Modify await_operator to dinamically get deployment name from csv when OLM is true (istio-ecosystem#1874) Update update-deps flow with 1.30 and remove 1.27 branch (istio-ecosystem#1875) tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) Add 1.30.0-alpha.2 charts (istio-ecosystem#1854) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1872) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) Add operator `TLSConfig` and sync with APIServer TLS profile on openshift (istio-ecosystem#1513) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1851) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
May 1, 2026
* upstream/main: (41 commits) fix: handle repos with different release branch naming in crd-schema-checker (istio-ecosystem#1897) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1899) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1896) Fix test docs test failure (istio-ecosystem#1890) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1892) Skip processing aliases referencing pre-released versions in EOL updater (istio-ecosystem#1883) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1886) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1884) Fixing two problems with our hack/update-istio.sh script (istio-ecosystem#1882) test: Modify await_operator to dinamically get deployment name from csv when OLM is true (istio-ecosystem#1874) Update update-deps flow with 1.30 and remove 1.27 branch (istio-ecosystem#1875) tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) Add 1.30.0-alpha.2 charts (istio-ecosystem#1854) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1872) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
May 4, 2026
* upstream/main: (41 commits) fix: handle repos with different release branch naming in crd-schema-checker (istio-ecosystem#1897) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1899) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1896) Fix test docs test failure (istio-ecosystem#1890) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1892) Skip processing aliases referencing pre-released versions in EOL updater (istio-ecosystem#1883) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1886) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1884) Fixing two problems with our hack/update-istio.sh script (istio-ecosystem#1882) test: Modify await_operator to dinamically get deployment name from csv when OLM is true (istio-ecosystem#1874) Update update-deps flow with 1.30 and remove 1.27 branch (istio-ecosystem#1875) tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) Add 1.30.0-alpha.2 charts (istio-ecosystem#1854) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1872) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are failures when the test is executed on hosted cluster because by default changing the TLS profile
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Related Issue/PR #
Additional information: