Fix serves metrics securely test#1860
Conversation
It fixes the hard-coded cluster role name sailoperator-metrics-reader in serves metrics securely test. The cluster role name may vary since it is dynamically created {{ .Values.name }}-metrics-reader
Signed-off-by: mkralik3 <mkralik@redhat.com>
fe1c0c4 to
fcf65a4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1860 +/- ##
==========================================
+ Coverage 80.22% 80.57% +0.35%
==========================================
Files 51 51
Lines 2569 2569
==========================================
+ Hits 2061 2070 +9
+ Misses 385 379 -6
+ Partials 123 120 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
In response to a cherrypick label: #1860 failed to apply on top of branch "release-1.26": |
|
In response to a cherrypick label: new issue created for failed cherrypick: #1861 |
|
In response to a cherrypick label: #1860 failed to apply on top of branch "release-1.27": |
|
In response to a cherrypick label: new issue created for failed cherrypick: #1862 |
|
In response to a cherrypick label: #1860 failed to apply on top of branch "release-1.28": |
|
In response to a cherrypick label: new issue created for failed cherrypick: #1863 |
|
In response to a cherrypick label: #1860 failed to apply on top of branch "release-1.29": |
|
In response to a cherrypick label: new issue created for failed cherrypick: #1864 |
* upstream/main: (26 commits) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) Add operator `TLSConfig` and sync with APIServer TLS profile on openshift (istio-ecosystem#1513) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1851) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1850) Add documentation for resource customization (istio-ecosystem#1292) refactor error and status condition handling (istio-ecosystem#1807) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1848) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1845) feat: add targetRef field to ZTunnel CRD (istio-ecosystem#1259) Add 1.29.2 and 1.28.6 versions (istio-ecosystem#1844) Use typed Go structs for FIPS values instead of helm.Values (istio-ecosystem#1695) Add helm.sh/helm/v3 to license allowlist alongside v4 (istio-ecosystem#1840) Update getLatestVersionByPrefix helm to v4 on update_deps.sh (istio-ecosystem#1833) Update kustomization files with registry.istio.io (istio-ecosystem#1829) Improve testing images tags for OLM and Operator images (istio-ecosystem#1819) Automator: Update EOL Istio versions in istio-ecosystem/sail-operator@main (istio-ecosystem#1821) ...
It fixes the hard-coded cluster role name sailoperator-metrics-reader in serves metrics securely test. The cluster role name may vary since it is dynamically created {{ .Values.name }}-metrics-reader
Signed-off-by: mkralik3 <mkralik@redhat.com>
It fixes the hard-coded cluster role name sailoperator-metrics-reader in serves metrics securely test. The cluster role name may vary since it is dynamically created {{ .Values.name }}-metrics-reader
Signed-off-by: mkralik3 <mkralik@redhat.com>
It fixes the hard-coded cluster role name sailoperator-metrics-reader in serves metrics securely test. The cluster role name may vary since it is dynamically created {{ .Values.name }}-metrics-reader
Signed-off-by: mkralik3 <mkralik@redhat.com>
* fix: use operator name as prefix in metrics-reader clusterrole. (#1762) Signed-off-by: riccardo1991 <riccardo1991@users.noreply.github.com> * Fix serves metrics securely test (#1860) It fixes the hard-coded cluster role name sailoperator-metrics-reader in serves metrics securely test. The cluster role name may vary since it is dynamically created {{ .Values.name }}-metrics-reader Signed-off-by: mkralik3 <mkralik@redhat.com> --------- Signed-off-by: riccardo1991 <riccardo1991@users.noreply.github.com> Signed-off-by: mkralik3 <mkralik@redhat.com> Co-authored-by: riccardo1991 <riccardo1991@users.noreply.github.com>
It fixes the hard-coded cluster role name sailoperator-metrics-reader in serves metrics securely test. The cluster role name may vary since it is dynamically created {{ .Values.name }}-metrics-reader
Signed-off-by: mkralik3 <mkralik@redhat.com>
* upstream/release-1.28: Fix serves metrics securely test (istio-ecosystem#1860) (istio-ecosystem#1867)
It fixes the hard-coded cluster role name sailoperator-metrics-reader in serves metrics securely test. The cluster role name may vary since it is dynamically created {{ .Values.name }}-metrics-reader
Signed-off-by: mkralik3 <mkralik@redhat.com>
* upstream/release-1.27: Fix serves metrics securely test (istio-ecosystem#1860) (istio-ecosystem#1866)
* upstream/release-1.26: Fix serves metrics securely test (istio-ecosystem#1860) (istio-ecosystem#1865)
* upstream/release-1.26: Fix serves metrics securely test (istio-ecosystem#1860) (istio-ecosystem#1865)
* upstream/release-1.27: Fix serves metrics securely test (istio-ecosystem#1860) (istio-ecosystem#1866)
* upstream/main: (27 commits) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) Add operator `TLSConfig` and sync with APIServer TLS profile on openshift (istio-ecosystem#1513) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1851) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1850) Add documentation for resource customization (istio-ecosystem#1292) refactor error and status condition handling (istio-ecosystem#1807) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1848) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1845) feat: add targetRef field to ZTunnel CRD (istio-ecosystem#1259) Add 1.29.2 and 1.28.6 versions (istio-ecosystem#1844) Use typed Go structs for FIPS values instead of helm.Values (istio-ecosystem#1695) Add helm.sh/helm/v3 to license allowlist alongside v4 (istio-ecosystem#1840) Update getLatestVersionByPrefix helm to v4 on update_deps.sh (istio-ecosystem#1833) Update kustomization files with registry.istio.io (istio-ecosystem#1829) Improve testing images tags for OLM and Operator images (istio-ecosystem#1819) ...
* upstream/release-1.27: Fix serves metrics securely test (istio-ecosystem#1860) (istio-ecosystem#1866)
* upstream/main: (31 commits) Update update-deps flow with 1.30 and remove 1.27 branch (istio-ecosystem#1875) tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) Add 1.30.0-alpha.2 charts (istio-ecosystem#1854) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1872) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) Add operator `TLSConfig` and sync with APIServer TLS profile on openshift (istio-ecosystem#1513) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1851) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1850) Add documentation for resource customization (istio-ecosystem#1292) refactor error and status condition handling (istio-ecosystem#1807) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1848) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1845) feat: add targetRef field to ZTunnel CRD (istio-ecosystem#1259) Add 1.29.2 and 1.28.6 versions (istio-ecosystem#1844) Use typed Go structs for FIPS values instead of helm.Values (istio-ecosystem#1695) ...
* upstream/main: (35 commits) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1886) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1884) Fixing two problems with our hack/update-istio.sh script (istio-ecosystem#1882) test: Modify await_operator to dinamically get deployment name from csv when OLM is true (istio-ecosystem#1874) Update update-deps flow with 1.30 and remove 1.27 branch (istio-ecosystem#1875) tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) Add 1.30.0-alpha.2 charts (istio-ecosystem#1854) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1872) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) Add operator `TLSConfig` and sync with APIServer TLS profile on openshift (istio-ecosystem#1513) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1851) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1850) Add documentation for resource customization (istio-ecosystem#1292) refactor error and status condition handling (istio-ecosystem#1807) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1848) ...
* upstream/main: (39 commits) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1896) Fix test docs test failure (istio-ecosystem#1890) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1892) Skip processing aliases referencing pre-released versions in EOL updater (istio-ecosystem#1883) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1886) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1884) Fixing two problems with our hack/update-istio.sh script (istio-ecosystem#1882) test: Modify await_operator to dinamically get deployment name from csv when OLM is true (istio-ecosystem#1874) Update update-deps flow with 1.30 and remove 1.27 branch (istio-ecosystem#1875) tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) Add 1.30.0-alpha.2 charts (istio-ecosystem#1854) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1872) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) Add operator `TLSConfig` and sync with APIServer TLS profile on openshift (istio-ecosystem#1513) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1851) ...
* upstream/main: (41 commits) fix: handle repos with different release branch naming in crd-schema-checker (istio-ecosystem#1897) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1899) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1896) Fix test docs test failure (istio-ecosystem#1890) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1892) Skip processing aliases referencing pre-released versions in EOL updater (istio-ecosystem#1883) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1886) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1884) Fixing two problems with our hack/update-istio.sh script (istio-ecosystem#1882) test: Modify await_operator to dinamically get deployment name from csv when OLM is true (istio-ecosystem#1874) Update update-deps flow with 1.30 and remove 1.27 branch (istio-ecosystem#1875) tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) Add 1.30.0-alpha.2 charts (istio-ecosystem#1854) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1872) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) ...
* upstream/main: (41 commits) fix: handle repos with different release branch naming in crd-schema-checker (istio-ecosystem#1897) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1899) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1896) Fix test docs test failure (istio-ecosystem#1890) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1892) Skip processing aliases referencing pre-released versions in EOL updater (istio-ecosystem#1883) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1886) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1884) Fixing two problems with our hack/update-istio.sh script (istio-ecosystem#1882) test: Modify await_operator to dinamically get deployment name from csv when OLM is true (istio-ecosystem#1874) Update update-deps flow with 1.30 and remove 1.27 branch (istio-ecosystem#1875) tests: Skip TLS profile change test when is executed on Hosted clusters (istio-ecosystem#1873) Add 1.30.0-alpha.2 charts (istio-ecosystem#1854) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1872) Using crane instead of skopeo which is not available in the build-tools (istio-ecosystem#1870) Sync min tls version from `TLSConfig` to `Istio` (istio-ecosystem#1859) Fix serves metrics securely test (istio-ecosystem#1860) refactor: vendor kubernetes manifests into the repo (istio-ecosystem#1853) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1856) Modify "download-charts" script for alpha/beta releases (istio-ecosystem#1852) ...
What type of PR is this?
What this PR does / why we need it:
It fixes the hard-coded cluster role name
sailoperator-metrics-readerinserves metrics securelytest. The cluster role name may vary since it is dynamically created{{ .Values.name }}-metrics-readerWhich issue(s) this PR fixes:
Fixes: #1858
Related Issue/PR #
Additional information: