[release-1.29] Fix serves metrics securely test (#1860)#1867#1868
Merged
istio-testing merged 2 commits intoApr 22, 2026
Merged
Conversation
…o-ecosystem#1762) Signed-off-by: riccardo1991 <riccardo1991@users.noreply.github.com>
It fixes the hard-coded cluster role name sailoperator-metrics-reader in serves metrics securely test. The cluster role name may vary since it is dynamically created {{ .Values.name }}-metrics-reader
Signed-off-by: mkralik3 <mkralik@redhat.com>
mkralik3
force-pushed
the
fixMetricsTest-1.29
branch
from
3cb56e4 to
e37defd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.29 #1868 +/- ##
================================================
- Coverage 80.94% 79.91% -1.04%
================================================
Files 50 50
Lines 2488 3111 +623
================================================
+ Hits 2014 2486 +472
- Misses 349 502 +153
+ Partials 125 123 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fjglira
approved these changes
Apr 22, 2026
istio-testing
merged commit e7d8371
into
istio-ecosystem:release-1.29
19 of 20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1864