Add dataclass (configclass) decorator to DataInfoCfg #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also saw this yesterday but was going to add this as a part of a bigger PR. Since you already did it, might as well merge it now. Thanks! |
Mayankm96
approved these changes
Apr 15, 2023
Mayankm96
added a commit
that referenced
this pull request
Jul 24, 2023
pascal-roth
added a commit
that referenced
this pull request
Aug 18, 2025
…d fixes tests (#65) ClassVar not correctly destroyed, thus removing it (follow changes of original RayCaster). Fixing tests to comply with changes of our internal code with 1.4.1. - Bug fix (non-breaking change which fixes an issue) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Co-authored-by: zrene <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a one line fix for a typo on the
DataInfoCfgdataclass.Type of change
Checklist
pre-commitchecks with./orbit.sh --formatconfig/extension.tomlfile