Fixed WithEndpoint to require a protocol, and be the same as the environment variable #4

Kaushal28 · 2023-04-17T11:33:11Z

When using the OTLP exporter, the WithEndpoint option requires an hostname, without the protocol.
However, the X_ENDPOINT environment variables requires an endpoint, including the protocol.

This was misleading, as both config have very similar names, but expect different values.

So, Fixed WithEndpoint to require a protocol, and be the same as the environment variable

CODEOWNERS

exporters/otlp/otlptrace/internal/otlpconfig/options_test.go

Bump google.golang.org/grpc from 1.54.0 to 1.55.0 in /bridge/opentracing/test Bump github.com/prometheus/client_golang from 1.15.0 to 1.15.1 in /example/view Bump github.com/prometheus/client_model from 0.3.0 to 0.4.0 in /exporters/prometheus Bump github.com/prometheus/client_golang from 1.15.0 to 1.15.1 in /exporters/prometheus Bump google.golang.org/grpc from 1.54.0 to 1.55.0 in /exporters/otlp/otlptrace Bump google.golang.org/grpc from 1.54.0 to 1.55.0 in /exporters/otlp/otlpmetric/otlpmetricgrpc Bump google.golang.org/grpc from 1.54.0 to 1.55.0 in /exporters/otlp/otlptrace/otlptracegrpc Bump google.golang.org/grpc from 1.54.0 to 1.55.0 in /exporters/otlp/otlpmetric Bump google.golang.org/grpc from 1.54.0 to 1.55.0 in /example/otel-collector Bump github.com/prometheus/client_golang from 1.15.0 to 1.15.1 in /example/prometheus Bump golang.org/x/sys from 0.7.0 to 0.8.0 in /sdk

* Remove deprecated `metric/instrument` * Apply suggestions from code review --------- Co-authored-by: Robert Pająk <[email protected]>

Remove self-reference to the package in the expandable interfaces.

The `Option` type was replaced with `InstrumentOption` when the `metric/instrument` package was moved to `metric`.

* Add semconv/v1.19.0 Includes adding semconv/internal/v3/ to support the move of the semantic convention HTTPUserAgentKey to the new key UserAgentOriginalKey * Update CHANGELOG.md Co-authored-by: Robert Pająk <[email protected]> * format http.go.tmpl using tabs instead of spaces * update http.go.tmpl to use v3 of semconv/internal * Generate attribute_group.go --------- Co-authored-by: Robert Pająk <[email protected]> Co-authored-by: Anthony Mirabella <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>

…y#4058) * Document how to pass attributes for all record methods * Update based on feedback

… ci workflow (open-telemetry#4074) Using cache-dependency-path (which is now a built-in functionality in actions/setup-go), the speed of runs on MacOS can be improved. Refs: open-telemetry#3911 Co-authored-by: Robert Pająk <[email protected]> Co-authored-by: Chester Cheung <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>

* added version.go and test file for issue 2143 * added license in metric versiont_test * goimport file linting * update trace version to v.1.13.0 and metric to 0.36.0 * Update sdk/metric/version.go Co-authored-by: Robert Pająk <[email protected]> * using asser.Regxp * changing regex string as per recommendations Signed-off-by: ChillOrb <[email protected]> * changing regex string as per recommendations Signed-off-by: ChillOrb <[email protected]> * reverting go mod and go sum changes Signed-off-by: ChillOrb <[email protected]> * trace and metric version bump up Signed-off-by: ChillOrb <[email protected]> * version update in sdk/metric , sdk/trace Signed-off-by: ChillOrb <[email protected]> * doc typo fix Signed-off-by: ChillOrb <[email protected]> * Apply suggestions from code review --------- Signed-off-by: ChillOrb <[email protected]> Co-authored-by: Chester Cheung <[email protected]> Co-authored-by: Robert Pająk <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>

Co-authored-by: Chester Cheung <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>

* Add measurement docs to metric API Based on user feedback, how measurements are made with observable instruments is not immediately clear to new users. This adds documentation intended to help guide these users. * Apply feedback * Apply feedback * Remove backticks * Apply suggestions from code review Co-authored-by: Robert Pająk <[email protected]> * Update metric/meter.go Co-authored-by: Robert Pająk <[email protected]> --------- Co-authored-by: Robert Pająk <[email protected]> Co-authored-by: Chester Cheung <[email protected]>

* sdk/resource: Fix build for BSD OSes * Add changelog * Update header in changelog --------- Co-authored-by: Tyler Yahn <[email protected]>

* Add Telemetry Stability label * Update sdk/resource/doc.go * Update doc.go --------- Co-authored-by: Chester Cheung <[email protected]>

…telemetry#4087) Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.8.0 to 0.9.1. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.8.0...v0.9.1) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump github.com/cloudflare/circl from 1.3.1 to 1.3.3 in /internal/tools

Co-authored-by: Chester Cheung <[email protected]>

Signed-off-by: Chen Xu <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>

* Add semconv/v1.20.0 * Update changelog * Change http.flavor to net.protocol.(name|version) * Update comments in httpconv * Fix vanity import * Update CHANGELOG.md Co-authored-by: Tyler Yahn <[email protected]> --------- Co-authored-by: Chester Cheung <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>

strings.Cut() generates less garbage as it does not allocate the slice to hold parts.

* Resolve inconsistent import comments in sdk/metric * update changelog * Apply suggestions from code review Co-authored-by: Tyler Yahn <[email protected]> * Update CHANGELOG.md --------- Co-authored-by: Chester Cheung <[email protected]> Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Robert Pająk <[email protected]>

Bumps [lycheeverse/lychee-action](https://github.com/lycheeverse/lychee-action) from 1.7.0 to 1.8.0. - [Release notes](https://github.com/lycheeverse/lychee-action/releases) - [Commits](lycheeverse/lychee-action@v1.7.0...v1.8.0) --- updated-dependencies: - dependency-name: lycheeverse/lychee-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /exporters/zipkin Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /bridge/opentracing/test Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /schema Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /exporters/otlp/internal/retry Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /exporters/prometheus Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /exporters/stdout/stdoutmetric Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /exporters/otlp/otlptrace Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /exporters/otlp/otlpmetric Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /exporters/otlp/otlpmetric/otlpmetricgrpc Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /exporters/otlp/otlpmetric/otlpmetrichttp Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /exporters/otlp/otlptrace/otlptracegrpc Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /exporters/stdout/stdouttrace Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /exporters/otlp/otlptrace/otlptracehttp Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /metric Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /trace Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /exporters/jaeger Bump codecov/codecov-action from 3.1.3 to 3.1.4 Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /sdk/metric Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /bridge/opencensus Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /bridge/opentracing Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 in /sdk Bump github.com/stretchr/testify from 1.8.2 to 1.8.3

* Update versions * Prepare stable-v1 for version v1.16.0 * Prepare experimental-metrics for version v0.39.0 * Update changelog

* [chore] Refine generate Make target * Do not run porto in go-generate * Update Makefile --------- Co-authored-by: Chester Cheung <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>

* Simplify documentation guidelines * Add info how to localy run pkg.go.dev

@pellared

* Add @pellared as maintainer Signed-off-by: Anthony J Mirabella <[email protected]> * Add @pellared as maintainer in CODEOWNERS --------- Signed-off-by: Anthony J Mirabella <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>

@Aneurysm9

* Move @Aneurysm9 to approver Signed-off-by: Anthony J Mirabella <[email protected]> * Remove @Aneurysm9 from CODEOWNERS --------- Signed-off-by: Anthony J Mirabella <[email protected]> Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>

…n-telemetry#4140) Co-authored-by: Tyler Yahn <[email protected]>

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3.1.3...v3.1.4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* sdk/metric: Log empty meter name * Avoid magic numbers * Lint * Apply suggestions from code review Co-authored-by: Tyler Yahn <[email protected]> * Update log message * Apply suggestion --------- Co-authored-by: Tyler Yahn <[email protected]>

) * [chore] Update Project Status * Fornat table * Update README.md Co-authored-by: Damien Mathieu <[email protected]> --------- Co-authored-by: Damien Mathieu <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>

…rnal/tools (open-telemetry#4177) * Bump github.com/golangci/golangci-lint in /internal/tools Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.52.2 to 1.53.2. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.52.2...v1.53.2) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Update golangci lint configuration --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tyler Yahn <[email protected]>

…etry#4145)

…y#4154)

Bump go.opentelemetry.io/build-tools/crosslink from 0.7.0 to 0.8.0 in /internal/tools Bump go.opentelemetry.io/build-tools/dbotconf from 0.7.0 to 0.8.0 in /internal/tools Bump go.opentelemetry.io/build-tools/multimod from 0.7.0 to 0.8.0 in /internal/tools Bump go.opentelemetry.io/build-tools/semconvgen from 0.7.0 to 0.8.0 in /internal/tools Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /exporters/otlp/otlptrace Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /exporters/zipkin Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /exporters/otlp/otlptrace/otlptracehttp Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /bridge/opentracing/test Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /exporters/otlp/internal/retry Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /exporters/otlp/otlpmetric/otlpmetrichttp Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /exporters/otlp/otlptrace/otlptracegrpc Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /exporters/jaeger Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /exporters/stdout/stdouttrace Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /exporters/stdout/stdoutmetric Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /exporters/otlp/otlpmetric Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /schema Bump github.com/itchyny/gojq from 0.12.12 to 0.12.13 in /internal/tools Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /metric Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /trace Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /exporters/prometheus Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /exporters/otlp/otlpmetric/otlpmetricgrpc Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /bridge/opencensus Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /sdk/metric Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /bridge/opentracing Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 in /sdk

* Warn instead of Info log instrument conflict * Add change to changelog

Co-authored-by: Chester Cheung <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>

Update the main branch of the fork

…ronment variable

Fixed review comments Fixed scheme addition Revert "Fixed scheme addition" This reverts commit 2c9cf15. Revert "Revert "Fixed scheme addition"" This reverts commit 12e7600. fixed string conca

Kaushal28 marked this pull request as ready for review April 20, 2023 06:41

shubham-bansal96 approved these changes Apr 20, 2023

View reviewed changes

Kaushal28 force-pushed the issue-3730 branch 2 times, most recently from 72c0335 to a135353 Compare April 20, 2023 11:12

shubham-bansal96 reviewed Apr 21, 2023

View reviewed changes

CODEOWNERS Show resolved Hide resolved

Kaushal28 requested review from samkulkarni20 and ApsTomar April 21, 2023 05:07

shubham-bansal96 reviewed Apr 21, 2023

View reviewed changes

exporters/otlp/otlptrace/internal/otlpconfig/options_test.go Outdated Show resolved Hide resolved

Kaushal28 force-pushed the issue-3730 branch from 6369516 to 185a12d Compare April 21, 2023 12:44

ApsTomar approved these changes Apr 24, 2023

View reviewed changes

opentelemetrybot and others added 20 commits May 7, 2023 08:11

Remove the deprecated metric/instrument package (open-telemetry#4055)

4f4edec

* Remove deprecated `metric/instrument` * Apply suggestions from code review --------- Co-authored-by: Robert Pająk <[email protected]>

Update metric iface warnings (open-telemetry#4056)

2aadf65

Remove self-reference to the package in the expandable interfaces.

Add comment on all uses of embedded types (open-telemetry#4059)

07bf591

Fix the broken [Option] link in metric docs (open-telemetry#4057)

476d00a

The `Option` type was replaced with `InstrumentOption` when the `metric/instrument` package was moved to `metric`.

Fix article in metric API docs (open-telemetry#4054)

6f04547

Document how to pass attributes for all record methods (open-telemetr…

02c0001

…y#4058) * Document how to pass attributes for all record methods * Update based on feedback

[chore] Pin otel-specification hyperlinks (open-telemetry#4033)

4d473d1

Co-authored-by: Chester Cheung <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>

sdk/resource: Fix build for BSD OSes (open-telemetry#4077)

7dea222

* sdk/resource: Fix build for BSD OSes * Add changelog * Update header in changelog --------- Co-authored-by: Tyler Yahn <[email protected]>

sdk/resource: Add Telemetry Stability label (open-telemetry#4080)

24e8d2e

* Add Telemetry Stability label * Update sdk/resource/doc.go * Update doc.go --------- Co-authored-by: Chester Cheung <[email protected]>

dependabot updates Sun May 14 14:40:44 UTC 2023 (open-telemetry#4089)

c04c04c

Bump github.com/cloudflare/circl from 1.3.1 to 1.3.3 in /internal/tools

[website_docs] Update path to spec, run formatter (open-telemetry#4084)

1dff818

Co-authored-by: Chester Cheung <[email protected]>

[SDK][Trace] Add tests for default id generator (open-telemetry#4043)

fadd3d6

Signed-off-by: Chen Xu <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>

Use strings.Cut() instead of string.SplitN() (open-telemetry#4049)

f95bee2

strings.Cut() generates less garbage as it does not allocate the slice to hold parts.

andrew-womeldorf and others added 29 commits May 19, 2023 09:25

Release v1.16.0/v0.39.0 -- Stable Metric API (open-telemetry#4100)

e0852d6

* Update versions * Prepare stable-v1 for version v1.16.0 * Prepare experimental-metrics for version v0.39.0 * Update changelog

[chore] Refine generate Make target (open-telemetry#4097)

2df12eb

* [chore] Refine generate Make target * Do not run porto in go-generate * Update Makefile --------- Co-authored-by: Chester Cheung <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>

Marked Metrics as stable (open-telemetry#4129)

46f2ce5

[chore] Update documentation guidelines (open-telemetry#4136)

ff9fa33

* Simplify documentation guidelines * Add info how to localy run pkg.go.dev

[chore] Clarify that internal and test packages do not need docs (ope…

b2246d5

…n-telemetry#4140) Co-authored-by: Tyler Yahn <[email protected]>

sdk/metrics: Fix MeterProvider.Meter Go doc (open-telemetry#4152)

f956587

semconv: Stop generating httpconv.go, netconv.go, http.go (open-telem…

b4faa3d

…etry#4145)

Return noop meters once the provider has been shutdown (open-telemetr…

be82610

…y#4154)

[chore] Update dependabot-pr branch name (open-telemetry#4191)

a6a916e

Warn instead of Info log instrument conflict (open-telemetry#4202)

ce46eb5

* Warn instead of Info log instrument conflict * Add change to changelog

Common weights for go pages (open-telemetry#4211)

93a5ba1

Upgrade go.opentelemetry.io/proto/otlp to v0.20.0 (open-telemetry#4213)

e7ff6a3

[chore] Add go-work Make target (open-telemetry#4199)

4f48154

Co-authored-by: Chester Cheung <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>

Merge pull request #7 from open-telemetry/main

1930f09

Update the main branch of the fork

Fixed WithEndpoint to require a protocol, and be the same as the envi…

ca8015a

…ronment variable

added support for adding scheme if not already present

1b1616b

Fixed unit tests

abb8ad5

Fixed review comments Fixed scheme addition Revert "Fixed scheme addition" This reverts commit 2c9cf15. Revert "Revert "Fixed scheme addition"" This reverts commit 12e7600. fixed string conca

Did the same changes for otlpmetrics

b40d8f1

Update the review comment on PR 4160

ede596c

parauliya force-pushed the issue-3730 branch from 185a12d to ede596c Compare July 4, 2023 09:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed WithEndpoint to require a protocol, and be the same as the environment variable #4

Fixed WithEndpoint to require a protocol, and be the same as the environment variable #4

Kaushal28 commented Apr 17, 2023 •

edited

Loading

Fixed WithEndpoint to require a protocol, and be the same as the environment variable #4

Are you sure you want to change the base?

Fixed WithEndpoint to require a protocol, and be the same as the environment variable #4

Conversation

Kaushal28 commented Apr 17, 2023 • edited Loading

Kaushal28 commented Apr 17, 2023 •

edited

Loading