Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semconv: Stop generating httpconv.go, netconv.go, http.go #4145

Merged

Conversation

pellared
Copy link
Member

@pellared pellared commented May 29, 2023

Next (and last) step after open-telemetry/opentelemetry-go-contrib#3817

Fixes #4081

@pellared pellared changed the title Stop generating httpconv and netconv packages Stop generating httpconv, netconv packages and http.go May 29, 2023
@pellared pellared changed the title Stop generating httpconv, netconv packages and http.go Stop generating httpconv.go, netconv.go and http.go May 29, 2023
@pellared pellared changed the title Stop generating httpconv.go, netconv.go and http.go semconv: Stop generating httpconv.go, netconv.go and http.go May 29, 2023
@pellared pellared marked this pull request as ready for review May 29, 2023 18:17
@pellared pellared changed the title semconv: Stop generating httpconv.go, netconv.go and http.go semconv: Stop generating httpconv.go, netconv.go, http.go May 29, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Tyler Yahn <[email protected]>
CHANGELOG.md Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #4145 (100d362) into main (bb867e6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4145   +/-   ##
=====================================
  Coverage   83.3%   83.3%           
=====================================
  Files        181     181           
  Lines      13928   13928           
=====================================
  Hits       11615   11615           
  Misses      2092    2092           
  Partials     221     221           

see 2 files with indirect coverage changes

@pellared pellared merged commit b4faa3d into open-telemetry:main Jun 5, 2023
@pellared pellared deleted the stop-generating-httpconv-netconv branch June 21, 2023 16:32
@MrAlias MrAlias added this to the v1.17.0 milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move httpconv and netconv to go-contrib
3 participants