-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cache-dependency-path
in actions/setup-go
#3911
Comments
Hey, I'd like to test the time benefit of this if possible. |
@pellared @Tijmen34 |
Is there really any work needed? It seems @Tijmen34's test showed this has very little impact. |
I actually do see some value in adding this to improve the speed of MacOS compatibility tests. It is however up for debate. |
@Tijmen34 I really like this commit: https://github.com/Tijmen34/opentelemetry-go/commit/22221455677144d26173711552c314e4206c157c
Feel free to open a PR 😉 |
Thanks, great to hear. PR has been opened, very happy that I have been able to contribute. 😄 |
… ci workflow (#4074) Using cache-dependency-path (which is now a built-in functionality in actions/setup-go), the speed of runs on MacOS can be improved. Refs: #3911 Co-authored-by: Robert Pająk <[email protected]> Co-authored-by: Chester Cheung <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
Fixed in #4074 |
With
actions/setup-go
updated tov4
the caching is enabled by default. We should consider settingcache-dependency-path: '**/go.sum'
. However, we need to ensure on a fork what is time diff benefit (if any).Originally posted by @pellared in #3901 (comment)
The text was updated successfully, but these errors were encountered: