Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk/metrics: Fix MeterProvider.Meter Go doc #4152

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

pellared
Copy link
Member

Fixes #4150

@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 31, 2023
@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels May 31, 2023
@MrAlias MrAlias added the documentation Provides helpful information label May 31, 2023
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #4152 (453bff2) into main (e2f8eca) will increase coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4152   +/-   ##
=====================================
  Coverage   83.3%   83.4%           
=====================================
  Files        181     181           
  Lines      13925   13925           
=====================================
+ Hits       11610   11614    +4     
+ Misses      2094    2090    -4     
  Partials     221     221           
Impacted Files Coverage Δ
sdk/metric/provider.go 100.0% <ø> (ø)

... and 1 file with indirect coverage changes

@pellared pellared merged commit f956587 into open-telemetry:main Jun 1, 2023
@pellared pellared deleted the fix-meter-godoc branch June 1, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics documentation Provides helpful information pkg:SDK Related to an SDK package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Fix Meter method Go doc
4 participants