Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: feat/dark-mode <- main #6103

Merged
merged 46 commits into from
Aug 10, 2023

Conversation

larseggert
Copy link
Collaborator

No description provided.

rjsparks and others added 30 commits July 13, 2023 11:29
* fix: restore ability to create status change documents

Fixes ietf-tools#5962

* chore: address review comment
…-tools#6007)

* fix: Make name/email lookups case-insensitive (ietf-tools#5972)

Use icontains so that looking up name or email is case insensitive
Added a test

Fixes: 5972

* fix: Use __iexact not __icontains
When a draft is submitted for manual processing, clarify that
no action is needed; the Secretariat has the next steps.

Fixes: ietf-tools#5918
* fix: Fix menu hover issue

Fixes ietf-tools#5702

* Fix leftmenu hover issue
When filtering nominees, `Questionnaire` implies `Accepted == yes`
so fix the dropdown test tosay that.

Fixes: ietf-tools#4688
…s#6021)

* fix:no history entry when changing RFC Editor note for doc

* fix:no history entry when changing RFC Editor note for doc

---------

Co-authored-by: Priyanka Narkar <[email protected]>
* fix: return 404 for non-existing revisions
Links to non-existing revisions to docs should return 404

* fix: change rfc/rev and search behaviour

* refactor: fix tab level

* fix: return 404 for rfc revision for bibtex
* fix: provide date for revisions in bibtex output

* refactor: change walrus to if's

* fix: specify particular revision for events
…eady has review request (fixes ietf-tools#3211) (ietf-tools#5425)

* Added check that if there is already review request for the document
in question, ignore the automatic suggestion for that document.
Fixes ietf-tools#3211.

* fix: dont block on open requests for a previous version. Add tests

---------

Co-authored-by: Nicolas Giard <[email protected]>
Co-authored-by: Robert Sparks <[email protected]>
* feat: support iab and iesg statements. Import iab statements. (ietf-tools#5895)

* feat: infrastructure for statements doctype

* chore: basic test framework

* feat: basic statement document view

* feat: show replaced statements

* chore: black

* fix: state help for statements

* fix: cleanout non-relevant email expansions

* feat: import iab statements, provide group statements tab

* fix: guard against running import twice

* feat: build redirect csv for iab statements

* fix: set document state on import

* feat: show published date on main doc view

* feat: handle pdf statements

* feat: create new and update statements

* chore: copyright block updates

* chore: remove flakes

* chore: black

* feat: add edit/new buttons for the secretariat

* fix: address PR ietf-tools#5895 review comments

* fix: pin pydantic until inflect catches up (ietf-tools#5901) (ietf-tools#5902)

* chore: re-un-pin pydantic
)

* feat: include submitter in email about submitted slides

fixes ietf-tools#6031

* chore: remove unintended whitespace change
* fix: Add editorial stream to proceedings

Fixes ietf-tools#5717

* fix: Move editorial stream after the irtf in proceedings
* Fix: Shows requested reviews for doc

* Changed template includes to only give required variables to them.
…ve (ietf-tools#6041)

* feat: allow openId to choose an unactive email if there are no active ones

* chore: correct typo

* chore: rename unactive to inactive
* fix: Improve layout of review table

* Progress

* Progress

* Final changes

* Fix tests

* Remove fluff

* Undo commits
- Remove "Unclassified" column header, which caused misalignment in the table body.

- Show the message author - previously displayed as `(None)`.
larseggert and others added 16 commits August 7, 2023 16:53
* fix: Clean up view_feedback_pending

- Remove "Unclassified" column header, which caused misalignment in the table body.

- Show the message author - previously displayed as `(None)`.

* feat: Reclassify nomcom feedback (ietf-tools#4669)

- There's a new `Chair/Advisor Tasks` menu item `Reclassify feedback`.

- I overloaded `view_feedback*` URLs with a `?reclassify` parameter.

- This adds a checkbox to each feedback message, and a `Reclassify` button
at the bottom of each feedback page.

- "Reclassifying" basically de-classifies the feedback, and punts it back
to the "Pending emails" view for reclassification.

- If a feedback has been applied to multiple nominees, declassifying it
from one nominee removes it from all.

* fix: Remove unused local variables

* fix: Fix some missing and mis-nested html

* test: Add tests for reclassifying feedback

* refactor: Substantial redesign of feedback reclassification

- Break out reclassify_feedback* as their own URLs and views,
  and revert changes to view_feedback*.html.

- Replace checkboxes with a Reclassify button on each message.

* fix: Remember to clear the feedback associations when reclassifying

* feat: Add an 'Overcome by events' feedback type

* refactor: When invoking reclassification from a view-feedback page, load the corresponding reclassify-feedback page

* fix: De-conflict migration with 0004_statements

Also change the coding style to match, and add a reverse migration.

* fix: Fix a test case to account for new feedback type

* fix: 842e730 broke the Back button

* refactor: Reclassify feedback directly instead of putting it back in the work queue

* fix: Adjust tests to new workflow

* refactor: Further refine reclassification to avoid redirects

* refactor: Impose a FeedbackTypeName ordering

Also add FeedbackTypeName.legend field, rather than synthesizing it every
time we classify or reclassify feedback.

In the reclassification forms, only show the relevant feedback types.

* refactor: Merge reclassify_feedback_* back into view_feedback_*

This means the "Reclassify" button is always present, but eliminates some
complexity.

* refactor: Add filter(used=True) on FeedbackTypeName querysets

* refactor: Add the new FeedbackTypeName to the reclassification success message

* fix: Secure reclassification against rogue nomcom members
* fix: Delete Person records when deleting a test nomcom

* fix: Decode test nomcom private key before printing
)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
…f-tools#6063)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
* Fix IESG State help text link (only)

* Intermediate checkpoint

* Correct URL filtering of state descriptions

* Unify help texts for document states

* Remove redundant load static from template

---------

Co-authored-by: Robert Sparks <[email protected]>
* fix: refactor how settings handles cache definitions

* chore: more english-speaker readable expression
@larseggert larseggert changed the title Feat/dark mode chore: feat/dark-more <- main Aug 9, 2023
@larseggert larseggert changed the title chore: feat/dark-more <- main chore: feat/dark-mode <- main Aug 9, 2023
@rjsparks rjsparks merged commit 57f23f5 into ietf-tools:feat/dark-mode Aug 10, 2023
1 check passed
@larseggert larseggert deleted the feat/dark-mode branch August 10, 2023 15:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.