Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clarify Questionnaire label (#4688) #6017

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

richsalz
Copy link
Collaborator

When filtering nominees, Questionnaire implies Accepted == yes so fix the dropdown test tosay that.

Fixes: #4688

When filtering nominees, `Questionnaire` implies `Accepted == yes`
so fix the dropdown test tosay that.

Fixes: ietf-tools#4688
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #6017 (a4e3fb2) into main (09f3477) will decrease coverage by 0.05%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main    #6017      +/-   ##
==========================================
- Coverage   88.67%   88.63%   -0.05%     
==========================================
  Files         288      288              
  Lines       40001    40004       +3     
==========================================
- Hits        35471    35457      -14     
- Misses       4530     4547      +17     
Impacted Files Coverage Δ
ietf/doc/views_stats.py 74.80% <ø> (ø)
ietf/ietfauth/widgets.py 84.61% <ø> (ø)
ietf/nomcom/views.py 92.90% <50.00%> (-0.22%) ⬇️
ietf/doc/utils.py 87.15% <100.00%> (+0.01%) ⬆️
ietf/nomcom/templatetags/nomcom_tags.py 70.83% <100.00%> (+3.64%) ⬆️
ietf/submit/forms.py 79.02% <100.00%> (+0.03%) ⬆️

... and 6 files with indirect coverage changes

@rjsparks rjsparks merged commit ebad948 into ietf-tools:main Jul 22, 2023
8 checks passed
@richsalz richsalz deleted the fix-4688-maybe branch July 22, 2023 23:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nomcom private page: filter separately on questionnaire yes/no
2 participants