Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit state button leads to 404. #6051

Closed
rjsparks opened this issue Jul 26, 2023 · 6 comments · Fixed by #6065
Closed

Edit state button leads to 404. #6051

rjsparks opened this issue Jul 26, 2023 · 6 comments · Fixed by #6065

Comments

@rjsparks
Copy link
Member

From Murray Kucherawy:

On an expired document (current example: https://datatracker.ietf.org/doc/draft-freed-smtp-limits/), the IESG state is showing “Dead”, which is correct. Next to that there’s an “Edit” button, which when pressed takes me to a 404 page.

I imagine either the button should be removed or greyed out (there’s nowhere to go from “Dead” unless a new version is posted), but other solutions are possible.
@rjsparks
Copy link
Member Author

cc: @mskucherawy

pselkirk added a commit to pselkirk/datatracker that referenced this issue Jul 31, 2023
@pselkirk
fix: Remove IESG state edit button when state is 'dead' (ietf-tools#6051
b1dd4ef 
)
@pselkirk pselkirk mentioned this issue Jul 31, 2023
Merged
rjsparks pushed a commit that referenced this issue Aug 7, 2023
@pselkirk
fix: Remove IESG state edit button when state is 'dead' (#6051) (#6065)
638f7ea
rjsparks added a commit that referenced this issue Aug 10, 2023
@larseggert @rjsparks
@nectostr @richsalz @PriyankaGitCom @alireza83 @maybe-hello-world @kivinen @NGPixel @kesara @jennifer-richards @pselkirk @depfu @jimfenton
chore: feat/dark-mode <- main (#6103)
57f23f5 
* chore: Remove unused "rendertest" stuff (#6015)

* fix: restore ability to create status change documents (#5963)

* fix: restore ability to create status change documents

Fixes #5962

* chore: address review comment

* fix: Provide human-friendly status in submission status API response (#6011)

Co-authored-by: nectostr <[email protected]>

* fix: Make name/email lookups case-insensitive (#5972) (#6007)

* fix: Make name/email lookups case-insensitive (#5972)

Use icontains so that looking up name or email is case insensitive
Added a test

Fixes: 5972

* fix: Use __iexact not __icontains

* fix: Clarify no-action-needed (#5918) (#6020)

When a draft is submitted for manual processing, clarify that
no action is needed; the Secretariat has the next steps.

Fixes: #5918

* fix: Fix menu hover issue (#6019)

* fix: Fix menu hover issue

Fixes #5702

* Fix leftmenu hover issue

* fix: Server error from api_get_session_materials() (#6025)

Fixes #5877

* fix: Clarify Questionnaire label (#4688) (#6017)

When filtering nominees, `Questionnaire` implies `Accepted == yes`
so fix the dropdown test tosay that.

Fixes: #4688

* chore: Merge from @martinthomson's rfc-txt-html (#6023)

* fix:no history entry when changing RFC Editor note for doc (#6021)

* fix:no history entry when changing RFC Editor note for doc

* fix:no history entry when changing RFC Editor note for doc

---------

Co-authored-by: Priyanka Narkar <[email protected]>

* fix: avoid deprecation warning on view_list() for objs without CommunityList

Fixes #5942

* fix: return 404 for non-existing revisions (#6014)

* fix: return 404 for non-existing revisions
Links to non-existing revisions to docs should return 404

* fix: change rfc/rev and search behaviour

* refactor: fix tab level

* fix: return 404 for rfc revision for bibtex

* fix: provide date for revisions in bibtex output (#6029)

* fix: provide date for revisions in bibtex output

* refactor: change walrus to if's

* fix: specify particular revision for events

* fix: review refactoring issue

fixes #5447

* fix:  Remove automatically suggested document for document that is already has review request (fixes #3211) (#5425)

* Added check that if there is already review request for the document
in question, ignore the automatic suggestion for that document.
Fixes #3211.

* fix: dont block on open requests for a previous version. Add tests

---------

Co-authored-by: Nicolas Giard <[email protected]>
Co-authored-by: Robert Sparks <[email protected]>

* feat: IAB statements (#5940)

* feat: support iab and iesg statements. Import iab statements. (#5895)

* feat: infrastructure for statements doctype

* chore: basic test framework

* feat: basic statement document view

* feat: show replaced statements

* chore: black

* fix: state help for statements

* fix: cleanout non-relevant email expansions

* feat: import iab statements, provide group statements tab

* fix: guard against running import twice

* feat: build redirect csv for iab statements

* fix: set document state on import

* feat: show published date on main doc view

* feat: handle pdf statements

* feat: create new and update statements

* chore: copyright block updates

* chore: remove flakes

* chore: black

* feat: add edit/new buttons for the secretariat

* fix: address PR #5895 review comments

* fix: pin pydantic until inflect catches up (#5901) (#5902)

* chore: re-un-pin pydantic

* feat: include submitter in email about submitted slides (#6033)

* feat: include submitter in email about submitted slides

fixes #6031

* chore: remove unintended whitespace change

* chore(dev): update .vscode/settings.json with new taskExplorer settings

* fix: Add editorial stream to proceedings (#6027)

* fix: Add editorial stream to proceedings

Fixes #5717

* fix: Move editorial stream after the irtf in proceedings

* fix: Add editorial stream to meeting materials (#6047)

Fixes #6042

* fix: Shows requested reviews for doc fixes (#6022)

* Fix: Shows requested reviews for doc

* Changed template includes to only give required variables to them.

* feat: allow openId to choose an unactive email if there are none active (#6041)

* feat: allow openId to choose an unactive email if there are no active ones

* chore: correct typo

* chore: rename unactive to inactive

* fix: Make review table more responsive (#6053)

* fix: Improve layout of review table

* Progress

* Progress

* Final changes

* Fix tests

* Remove fluff

* Undo commits

* ci: add --validate-html-harder to tests

* ci: add  --validate-html-harder to build.yml workflow

* fix: Set colspan to actual number of columns (#6069)

* fix: Clean up view_feedback_pending (#6070)

- Remove "Unclassified" column header, which caused misalignment in the table body.

- Show the message author - previously displayed as `(None)`.

* docs: Update LICENSE year

* fix: Remove IESG state edit button when state is 'dead' (#6051) (#6065)

* fix: Correctly order "last call requested" column in the IESG dashboard (#6079)

* ci: update dev sandbox init script to start memcached

* feat: Reclassify nomcom feedback (#6002)

* fix: Clean up view_feedback_pending

- Remove "Unclassified" column header, which caused misalignment in the table body.

- Show the message author - previously displayed as `(None)`.

* feat: Reclassify nomcom feedback (#4669)

- There's a new `Chair/Advisor Tasks` menu item `Reclassify feedback`.

- I overloaded `view_feedback*` URLs with a `?reclassify` parameter.

- This adds a checkbox to each feedback message, and a `Reclassify` button
at the bottom of each feedback page.

- "Reclassifying" basically de-classifies the feedback, and punts it back
to the "Pending emails" view for reclassification.

- If a feedback has been applied to multiple nominees, declassifying it
from one nominee removes it from all.

* fix: Remove unused local variables

* fix: Fix some missing and mis-nested html

* test: Add tests for reclassifying feedback

* refactor: Substantial redesign of feedback reclassification

- Break out reclassify_feedback* as their own URLs and views,
  and revert changes to view_feedback*.html.

- Replace checkboxes with a Reclassify button on each message.

* fix: Remember to clear the feedback associations when reclassifying

* feat: Add an 'Overcome by events' feedback type

* refactor: When invoking reclassification from a view-feedback page, load the corresponding reclassify-feedback page

* fix: De-conflict migration with 0004_statements

Also change the coding style to match, and add a reverse migration.

* fix: Fix a test case to account for new feedback type

* fix: 842e730 broke the Back button

* refactor: Reclassify feedback directly instead of putting it back in the work queue

* fix: Adjust tests to new workflow

* refactor: Further refine reclassification to avoid redirects

* refactor: Impose a FeedbackTypeName ordering

Also add FeedbackTypeName.legend field, rather than synthesizing it every
time we classify or reclassify feedback.

In the reclassification forms, only show the relevant feedback types.

* refactor: Merge reclassify_feedback_* back into view_feedback_*

This means the "Reclassify" button is always present, but eliminates some
complexity.

* refactor: Add filter(used=True) on FeedbackTypeName querysets

* refactor: Add the new FeedbackTypeName to the reclassification success message

* fix: Secure reclassification against rogue nomcom members

* fix: Print decoded key and fully clean up test nomcom (#6094)

* fix: Delete Person records when deleting a test nomcom

* fix: Decode test nomcom private key before printing

* test: Use correct time zone for test_statement_doc_view (#6064)

* chore(deps): update all npm dependencies for playwright (#6061)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* chore(deps): update all npm dependencies for dev/diff (#6062)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* chore(deps): update all npm dependencies for dev/coverage-action (#6063)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* fix: Hash cache key for default memcached cache (#6089)

* feat: Show docs that an AD hasn't balloted on that need ballots to progress (#6075)

* fix(doc): Unify help texts for document states (#6060)

* Fix IESG State help text link (only)

* Intermediate checkpoint

* Correct URL filtering of state descriptions

* Unify help texts for document states

* Remove redundant load static from template

---------

Co-authored-by: Robert Sparks <[email protected]>

* ci: fix sandbox start.sh memcached user

* fix: refactor how settings handles cache definitions (#6099)

* fix: refactor how settings handles cache definitions

* chore: more english-speaker readable expression

* fix: Cast cache key to str before calling encode (#6100)

---------

Co-authored-by: Robert Sparks <[email protected]>
Co-authored-by: Liubov Kurafeeva <[email protected]>
Co-authored-by: nectostr <[email protected]>
Co-authored-by: Rich Salz <[email protected]>
Co-authored-by: PriyankaN <[email protected]>
Co-authored-by: Priyanka Narkar <[email protected]>
Co-authored-by: Ali <[email protected]>
Co-authored-by: Roman Beltiukov <[email protected]>
Co-authored-by: Tero Kivinen <[email protected]>
Co-authored-by: Nicolas Giard <[email protected]>
Co-authored-by: Kesara Rathnayake <[email protected]>
Co-authored-by: Jennifer Richards <[email protected]>
Co-authored-by: Paul Selkirk <[email protected]>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Jim Fenton <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
@rjsparks rjsparks reopened this Aug 21, 2023
@rjsparks
Copy link
Member Author

Again from Murray (about draft-ietf-ecrit-lost-planned-changes):

This document was, I believe, in state "AD is watching" when it expired, which caused it to move to "Dead". They've now posted a new version, but I'm not able to restore it to a state where I can do anything to it.

The secretariat, at least, should be able to edit the IESG state away from Dead. Lets revisit why there was a 404 and if it's because ADs don't have permission, then change the template to not give ADs the button, but leave it for the Secretariat.

I'll work with Murray on what to do with this particular draft in the meantime.

Separately, we need to revisit the transition from "AD is watching" to "Dead" - it should probably be to "ID Exists".

@rjsparks
Copy link
Member Author

The original issue was raised while the document was expired, and editing iesg state was not available then because of this line:

datatracker/ietf/doc/views_draft.py

Line 91 in aa955f0

if (not doc.latest_event(type="started_iesg_process")) or doc.get_state_slug() == "expired":

@rjsparks
Copy link
Member Author

cc: @mskucherawy

@rjsparks
Copy link
Member Author

rjsparks commented Aug 30, 2023 •
edited
Loading

See #5560.

What we'll do for this issue in the meantime is make sure that the secretariat is always able to change the IESG state.

@rjsparks
Copy link
Member Author

rjsparks commented Sep 5, 2023

Closed with #6253

@rjsparks rjsparks closed this as completed Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove IESG state edit button when state is 'dead' pselkirk/datatracker
1 participant
@rjsparks