Skip to content

Conversation

@nmnobre
Copy link
Member

@nmnobre nmnobre commented Nov 2, 2025

Reason

Minor fixes. Some more performance improvements for the MFEM test suite. The new sidesets will be useful soon in #31134.

Design

Fixed bugs. Allowed parallel execution of LOR tests. Added sidesets in cubit.

Impact

On my workstation, with ./run_tests -C tests/mfem -j64 (this is in addition to #31798):

Configuration Before [s] After [s] Speedup
--dbg --compute-device cuda 149.4 82.8 80%
--dbg --compute-device cpu 153.1 85.1 80%
--opt --compute-device cuda 74.0 76.4 -3%
--opt --compute-device cpu 72.2 74.0 -2%

@nmnobre nmnobre requested a review from lindsayad as a code owner November 2, 2025 23:48
@moosebuild
Copy link
Contributor

Job Test, step Results summary on 1518e2e wanted to post the following:

Framework test summary

Compared against 4e5abd1 in job civet.inl.gov/job/3352081.

Removed tests

Added tests

Run time changes

Modules test summary

Compared against 4e5abd1 in job civet.inl.gov/job/3352081.

Removed tests

Added tests

Run time changes

@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on 1518e2e wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on 1518e2e wanted to post the following:

Framework coverage

4e5abd #31828 1518e2
Total Total +/- New
Rate 85.99% 85.99% - 100.00%
Hits 124384 124384 - 2
Misses 20272 20272 - 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see it's on the input mesh. I was baffled at first how changing from an ID to a name in the input file could change the output 😅

@lindsayad lindsayad merged commit 1e3a37a into idaholab:next Nov 3, 2025
69 checks passed
@nmnobre nmnobre deleted the fixes branch November 4, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants