-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Physics base class and a heat conduction example #25977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8426d8d to
0ac3227
Compare
|
Job Documentation on bd7ff03 wanted to post the following: View the site here This comment will be updated on new commits. |
0ac3227 to
caec5c9
Compare
9a69fca to
9a218a6
Compare
|
Job Coverage on bd7ff03 wanted to post the following: Framework coverage
Modules coverageHeat transfer
Full coverage reportsReports
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||||||||||||||||||||||||||||
ec9b742 to
89d27ff
Compare
|
Should probably move this forward. It doesnt have to be merged right right now, we could also wait until I dig deep into Component as Actions and assess if this is going to change the deal for Physics. I dont expect it to. But work on syntax for Components as Actions could enable interesting syntax for Physics. |
89d27ff to
116b734
Compare
248ffe2 to
87ec16c
Compare
lindsayad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
want to add a framework test?
|
need a framework class then? Thoughts on which physics? A test object? |
|
The thing that came to my mind is I thought we had an issue where we had a pretty large community (I thought it involved @dschwen at least) discussion about the Physics class but maybe i've lost my marbles. #25642 doesn't seem like it. |
|
I'm happy to implement that. |
|
A lot of the discussion is on the original Physics PR #25704
I do want that. I dont think it s feasible to do a |
Ah there it is, thanks |
87ec16c to
305e9e2
Compare
b84486e to
3c57e8f
Compare
Alex has been thoroughly reviewing this. I dont think there is anything left wrong! He did catch a lot of wrong things |
Oh don't worry, there's wrong stuff still. But just doc/typos so far 😄 |
modules/heat_transfer/doc/content/source/physics/HeatConductionFE.md
Outdated
Show resolved
Hide resolved
ecbbbcc to
41bd218
Compare
46811a1 to
859189e
Compare
859189e to
3e2d4cc
Compare
- fix documentation Apply suggestions from code review Co-authored-by: joshuahansel <[email protected]>
3e2d4cc to
8fa9f21
Compare
|
You should probably make a newsletter entry |
|
I ll make one for all of my January work soon |
8cd1198 to
bd7ff03
Compare
|
noice thanks a lot for the reviews. Merging so it makes the newsletters now for the tough part. NS, TM and THM |
Open for comments.
Once the dependent PRs are in, this could actually be merged
refs #25642
see original PR #25704
I dont think the syntax has been decided yet, so I m open to a CCB meeting on this
Currently the Physics base class only implements: