-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Unblock upcoming nonlinear solves and accelerate MFEM tests #31798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Job Documentation, step Docs: sync website on 2e0537d wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage, step Generate coverage on 2e0537d wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
lindsayad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do these changes lead to a speedup?
Apologies, I've edited the original post to make it clearer. What makes it faster is the LOR splitting bit. |
|
Notable changes since last reviewed: 1) moved the new class definitions to a separate header, so it can be included (and thus reused) in different compilation units, solving the non-unity build problems and 2) disabled multithreading for MFEM problems to avoid issues when adding objects for each thread (in particular in |
|
Job Test, step Results summary on 2e0537d wanted to post the following: Framework test summaryCompared against 2acb415 in job civet.inl.gov/job/3334968. Removed tests
Added tests
Run time changesModules test summaryCompared against 2acb415 in job civet.inl.gov/job/3334968. Removed testsAdded testsRun time changes
|
Reason
a) Unblock upcoming nonlinear solves using the MFEM backend affected by the changes in hypre 3.0 to PCG and GMRES.
b) Accelerate MFEM test executions.
Design
a) Extended
mfem::HyprePCGandmfem::HypreGMRESto reproduce the effect of mfem/mfem#5065.b) Split LOR tests into a different folder to gain some extra concurrency when running the test suite.
Impact
b) This mostly benefits people working on the MFEM backend, I don't expect us to see much difference on CIVET.
On my workstation, with
./run_tests -C tests/mfem -j64:--dbg --compute-device cuda--dbg --compute-device cpu--opt --compute-device cuda--opt --compute-device cpu