Interaction history fix #765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd-citing Revert "Add citing"
…ranch 'master' of github.com:KornbergFresnel/smarts
* Fixes to make the mini-city work nicely * Address comments
This reverts commit 5358fcd.
Traceback (most recent call last):
File "examples/multi_instance.py", line 192, in <module>
num_episodes=args.num_episodes,
AttributeError: 'Namespace' object has no attribute 'num_episodes'
* Fix ULTRA CI tests * Empty commit: run ULTRA CI Co-authored-by: Jenish Patel <[email protected]>
* First pass at ShowBase refactor into Renderer; Also added Provider base class. WIP * Updated the pybullet examples. +comments. * Added changelog entry. * find collidee by vehicle.id, not node in scene graph. misc. minor cleanup. * oops, had wrong issue number in CHANGELOG. * Made ShowBaseInstance class private. * Fixups from review: actually use Provider! * Added some comments to explain why overlapping SMARTS is still not a good idea. * fixups from review (better encapsulation) * fixed oops * don't use ShowBase clock for main simulation clock. * hide other sim_root nodes when rendering * Added simple multiple-renderers test.
* make done_creteria independent from events * update changelog
* Use possibly-shifted road network file when starting Sumo. * use unique name for shifted net file just in case. * Don't use a unique shifted_net filename every time afterall to avoid accumlation of cruft. * updated CHANGELOG * Fixed Changelog location. * Add CHANGELOG line for previous map offset fix saying that scenario maps need to be rebuilt.
* Added description for map creation * Mentioned paper in docs * change mention to paper to front page * update changelog * added description of lane connection * minor typos * add sub-headings Co-authored-by: Stephen Hockema <[email protected]>
* First pass adding renderer_optional param to SMARTS. * updated CHANGELOG * recategorized the renderer changes in CHANGELOG * Fixed location of changelog entry. * ok, I'm going to be more careful with CHANGELOG changes going forward! * Added new RendererException (per review) * Added shifted_map-AUTOGEN.net.xml to .gitignore (due to already-merged "maps_offset_fixes" PR). * Only create Renderer on demand (if camera-based sensor added).
Update open agent example
…gnal Make envision server can be killed by terminal signal.
* First pass at traffic history refactor to use sqlite instead of json. * misc cleanup and tying up loose ends, incl: - better smoothing of heading for very low vehicle speeds to reduce "wiggle" - added ability to set agent speed to imitation learning replacement example - added option to convert old JSON traffic histories to new sqlite .shf files - quiet netconvert's "Success" output when shifting maps - minor refactor of genhistories database creation code * Added copyright header. * added ability to use watch in sumo-gui/envision in near "realtime". * switch from log.warn to log.warning * updates from review * better comment, and the black code formatter likes to mess with me. * Fixups from review. * fixups from review: only replace passenger cars for imitation learning * removed near-real-time mode after review.
|
oops, chose |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix to ensure that traffic history data always starts at
sim_time = 0(even if the data file being imported does not).Closes #762.