Describe map creation #701

JingfeiPeng · 2021-03-23T14:04:58Z

This is to address #689 and #690

Added description of how to create a new map and edit maps.

Added explanation how to modify the map to allow users to create their own traffic routes. Since previous documentation exists for description of how route, flow and mission works, I added description on how route relates to the map.

Below shows how the doc would look after this change:

sah-huawei

Looks great! :)

Gamenot · 2021-04-01T21:03:05Z

docs/sim/scenario_studio.rst

@@ -93,3 +93,63 @@ And if you have an additional file you wish to turn into a map you can use the c

  python3 -m smarts.sstudio.sumo2mesh dataset_public/2lane_sharp/map.net.xml dataset_public/2lane_sharp/map.glb --format=glb
  python3 -m smarts.sstudio.sumo2mesh dataset_public/2lane_sharp/map.net.xml dataset_public/2lane_sharp/map.egg --format=egg
+
+
+The following describes a few basic operations to edit maps.


Possible subheading:

Suggested change

The following describes a few basic operations to edit maps.

Create map

---------------

Gamenot · 2021-04-01T21:04:42Z

docs/sim/scenario_studio.rst

+
+Then click on map to start creating new edges and lanes.
+
+Edit existing maps:


Possible subheading:

Suggested change

Edit existing maps:

Edit existing map

----------------------

Gamenot · 2021-04-01T21:08:42Z

Good work.

* Update evaluate and train to eval per episode * Fix tests and change normalization * Fix formatting * Record episode for train/eval at the same time * Train performance averages last eval_rate episodes * Add gap_mode and calculate generalization gap * Enable explore during eval for better comparison * Fix formatting * Adjust ci (#649) (#650) removes eager update strategy in ci automatically upgrades numpy version in ci * Fix averaging in record_episode * Only average scalars in record_episode * Check for scalar when calculating gap * Fix formatting * Fix bugs introduced by merge * Fix calculate_gap * Merge 0.4.15 version changes to master * Fix averaging over episodes * Fix formatting * Check eval_episodes is 0 before evaluation * Make evaluations run in parallel to training * Evaluate on train and test without exploration * Make train/test occur in one ray.get * Empty commit: create ultra-develop * Add on_shoulder event (#714) (#717) * add on_shoulder in events in observations * update changelogs * display grade intervals (episodes) * Update open agent example * Update changelog * Format * Remove episode_count * Remove episode_count from tests * Showbase refactor (#706) * First pass at ShowBase refactor into Renderer; Also added Provider base class. WIP * Updated the pybullet examples. +comments. * Added changelog entry. * find collidee by vehicle.id, not node in scene graph. misc. minor cleanup. * oops, had wrong issue number in CHANGELOG. * Made ShowBaseInstance class private. * Fixups from review: actually use Provider! * Added some comments to explain why overlapping SMARTS is still not a good idea. * fixups from review (better encapsulation) * fixed oops * don't use ShowBase clock for main simulation clock. * hide other sim_root nodes when rendering * Added simple multiple-renderers test. * WIP: Scenario density information available during training * isolate density extraction from non gb runs * WIP: Evaluate updated to record test densities * make done_creteria independent from events (#728) * make done_creteria independent from events * update changelog * map offset fixes (#727) * Use possibly-shifted road network file when starting Sumo. * use unique name for shifted net file just in case. * Don't use a unique shifted_net filename every time afterall to avoid accumlation of cruft. * updated CHANGELOG * Fixed Changelog location. * Add CHANGELOG line for previous map offset fix saying that scenario maps need to be rebuilt. * Describe map creation (#609 #689) (#701) * Added description for map creation * Mentioned paper in docs * change mention to paper to front page * update changelog * added description of lane connection * minor typos * add sub-headings Co-authored-by: Stephen Hockema <[email protected]> * Make envision server can be killed by terminal signal * Remove averaging over training episodes * Restructure evaluation_check with eval_mode = False * Fix formatting * Fix headless argument in ULTRA scripts * Refactored train, evaluate, coordinator & scenario data available from evaluate * updated config file * try split ci test method * updated gb tests & split evaluate tests into single and multi * clean up * formatted * fix tests * Add rollout_fragment_length and max_episode_steps to rllib * Add new flags to documentation * fix ci * Fix flag in example * Renderer Optional (#729) * First pass adding renderer_optional param to SMARTS. * updated CHANGELOG * recategorized the renderer changes in CHANGELOG * Fixed location of changelog entry. * ok, I'm going to be more careful with CHANGELOG changes going forward! * Added new RendererException (per review) * Added shifted_map-AUTOGEN.net.xml to .gitignore (due to already-merged "maps_offset_fixes" PR). * Only create Renderer on demand (if camera-based sensor added). * Ensure evaluation is not run in test_train.py * Check if log_dir doesn't exist in test_train.py * Fix typo in argument and set eval_episodes to 0 * Check if not exists for paths * Fix formatting * Update evaluate and train to evaluate per episode (#639) * Update evaluate and train to eval per episode * Fix tests and change normalization * Fix formatting * Record episode for train/eval at the same time * Train performance averages last eval_rate episodes * Add gap_mode and calculate generalization gap * Enable explore during eval for better comparison * Fix formatting * Fix averaging in record_episode * Only average scalars in record_episode * Check for scalar when calculating gap * Fix formatting * Fix bugs introduced by merge * Fix calculate_gap * Fix averaging over episodes * Fix formatting * Check eval_episodes is 0 before evaluation * Evaluate on train and test without exploration * Make train/test occur in one ray.get * Remove episode_count * Remove episode_count from tests * Remove averaging over training episodes * Restructure evaluation_check with eval_mode = False * Fix formatting * try split ci test method * Check for valid eval_episodes inside evaluation_check * Removed averaging feature of record_episode * Fix formatting Co-authored-by: Jenish Patel <[email protected]> * Merge with ultra-rllib-speedup-tests * Rename evaluation_task_id for training * fix ci * split evaluate tests into heavy and light * Update smarts/core/sumo_road_network.py * Simplify argument to ray.wait(...) * Remove print statements * Fix defaults * Fix eval-rate in docs * Scenario density analysis now available in non-gb mode * static evaluation models for test * refactored train/evaluate/episodes to store scenarios inside of episode.info object * fixed gb test error Co-authored-by: AlexLewandowski <[email protected]> Co-authored-by: Jeffer Jingfei Peng <[email protected]> Co-authored-by: Tucker <[email protected]> Co-authored-by: christianjans <[email protected]> Co-authored-by: sah-huawei <[email protected]> Co-authored-by: Stephen Hockema <[email protected]> Co-authored-by: Valax Kong <[email protected]> Co-authored-by: Tucker Alban <[email protected]>

JingfeiPeng requested review from Gamenot and sah-huawei March 23, 2021 14:41

This was linked to issues Mar 31, 2021

Describe Map Creation #689

Closed

Improve visibility of SMARTS Paper #690

Closed

sah-huawei approved these changes Apr 1, 2021

View reviewed changes

Gamenot approved these changes Apr 1, 2021

View reviewed changes

JingfeiPeng and others added 8 commits April 1, 2021 18:34

Added description for map creation

c4e0d24

Mentioned paper in docs

eae49eb

change mention to paper to front page

e7f5f1f

fix extra line in setup.rst

f7dcc27

update changelog

02b6b76

added description of lane connection

151d812

minor typos

627eb15

add sub-headings

70e02d9

JingfeiPeng force-pushed the describe_map_creation branch from 8c93d05 to 70e02d9 Compare April 1, 2021 22:36

JingfeiPeng merged commit 9ee1e5a into develop Apr 1, 2021

This was referenced Apr 3, 2021

Describe Map Creation #689

Closed

Improve visibility of SMARTS Paper #690

Closed

JingfeiPeng deleted the describe_map_creation branch April 13, 2021 22:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Describe map creation #701

Describe map creation #701

JingfeiPeng commented Mar 23, 2021 •

edited

Loading

sah-huawei left a comment

Gamenot Apr 1, 2021

Gamenot Apr 1, 2021

Gamenot commented Apr 1, 2021

	The following describes a few basic operations to edit maps.
	Create map
	---------------


		Then click on map to start creating new edges and lanes.

		Edit existing maps:

Describe map creation #701

Describe map creation #701

Conversation

JingfeiPeng commented Mar 23, 2021 • edited Loading

sah-huawei left a comment

Choose a reason for hiding this comment

Gamenot Apr 1, 2021

Choose a reason for hiding this comment

Gamenot Apr 1, 2021

Choose a reason for hiding this comment

Gamenot commented Apr 1, 2021

JingfeiPeng commented Mar 23, 2021 •

edited

Loading