Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sanity-test to make SMARTS setup easier #684

Closed
JingfeiPeng opened this issue Mar 16, 2021 · 1 comment · Fixed by #693
Closed

Add sanity-test to make SMARTS setup easier #684

JingfeiPeng opened this issue Mar 16, 2021 · 1 comment · Fixed by #693
Assignees
@JingfeiPeng
Labels
enhancement New feature or request

Comments

@JingfeiPeng
Copy link
Contributor

JingfeiPeng commented Mar 16, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently SMARTS setup is too overwhelming as it asks the user to run make test which takes a long time and freezes the laptop sometimes.

Describe the solution you'd like
We should create a "sanity-test" to just check the essential parts needed to run simulation.

Items to check:

  • Check $SUMO_HOME is properly set
  • Add "make sanity-test" in makefile
  • Update documentation to run "make sanity-test" instead of "make test"
  • Include only the necessary tests in "make test", excludes CPU-intensive tests such as test_rllib_example and test_rllib_hiway_env
@JingfeiPeng JingfeiPeng added the enhancement New feature or request label Mar 16, 2021
@JingfeiPeng JingfeiPeng self-assigned this Mar 16, 2021
@JingfeiPeng JingfeiPeng mentioned this issue Mar 18, 2021
Merged
JingfeiPeng added a commit that referenced this issue Mar 22, 2021
@JingfeiPeng
Add sanity test (#684) (#693)
35894fa 
* Added sanity test to test new user's setup

* Referred to sanity-test in readme

* Updated changelog
@JingfeiPeng JingfeiPeng linked a pull request Mar 22, 2021 that will close this issue
Sanity test #693
Merged
@JingfeiPeng
Copy link
Contributor Author

Fixed with #693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JingfeiPeng JingfeiPeng

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sanity test huawei-noah/SMARTS
1 participant
@JingfeiPeng