traffic history issues #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also gave traffic history vehicles an id that would allow them to be colored correctly.
JingfeiPeng
approved these changes
Apr 15, 2021
Gamenot
approved these changes
Apr 17, 2021
smarts/sstudio/genhistories.py
Outdated
| @@ -168,7 +168,7 @@ def create_output(self): | |||
| self._log.debug("shifting sim_times..") | |||
| mcur = dbconxn.cursor() | |||
| mcur.execute( | |||
| "UPDATE Trajectory SET sim_time = sim_time - (SELECT min(sim_time) FROM Trajectory)" | |||
| "UPDATE Trajectory SET sim_time = round(sim_time - (SELECT min(sim_time) FROM Trajectory), 3)" | |||
There was a problem hiding this comment.
I think that the digit place argument could at minimum be a descriptive class constant like TIME_DECIMAL_ACCURACY since the rounding decimal has a large impact on the behaviour of the history generator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main thing here is a fix for a bug introduced by PR #765: the update to
sim_timecaused some times to be imprecise, meaning that the "between" query done in thetraffic_history_provider.pysometimes misses.Also a miscellaneous update to give traffic history vehicles an id that will allow them to be colored as social agents (as opposed to ego agents) in Sumo, allowing for the 1 ego agent used by the history replacement script to stand out as red.