Skip to content

Clarification of time formats#10796

Closed
akasma74 wants to merge 20 commits into
home-assistant:currentfrom
akasma74:patch-14
Closed

Clarification of time formats#10796
akasma74 wants to merge 20 commits into
home-assistant:currentfrom
akasma74:patch-14

Conversation

@akasma74
Copy link
Copy Markdown
Contributor

I couldn't find anything in the current docs on time formats and thought it would be useful to give more details (rather than time | integer description) about ones available.

Description:

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

iantrich and others added 19 commits October 3, 2019 09:35
* Update changelog.markdown

* Update changelog.markdown
* Add Airly documentation

* Change ha_category

* Update airly.markdown file

* Update ha_release

* Fix ha_release version

Co-Authored-By: Klaas Schoute <klaas_schoute@hotmail.com>

* Update ha_release version

Co-Authored-By: Martin Hjelmare <marhje52@kth.se>

* Fix typo

Co-Authored-By: Martin Hjelmare <marhje52@kth.se>

* ✏️ Tweaks
* inital commit

* Update neato.markdown
* Move file to correct location

* Add heading
* Add scene apply docs

* Fix lint

* Fix formatting
)

* Removed missing link, updated future to past tense

* Minor changes
* Remove hipchat

* Remove hipchat
* Add documentation about new key: time_format

Based on PR home-assistant/home-asssitant#26940 this adds athe documentation about the new key + a warning on relying to much on the time based sensors.

* Remove time_format key as it doesn't belong in backend

* Remove time_format from the full configuration example

* Add info about time being represented as UTC
* add title option to stack cards

* Update horizontal-stack.markdown

* Update vertical-stack.markdown
I couldn't find anything in the current docs on time formats and thought it would be useful to give more details (rather than time | integer description) about ones available.
@probot-home-assistant probot-home-assistant Bot added next This PR goes into the next branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 15, 2019
@klaasnicolaas
Copy link
Copy Markdown
Member

Please rebase to the current branch and remove the notes / example tags

@klaasnicolaas klaasnicolaas added the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Oct 15, 2019
@akasma74 akasma74 changed the base branch from next to current October 15, 2019 13:27
@probot-home-assistant probot-home-assistant Bot added current This PR goes into the current branch and removed next This PR goes into the next branch labels Oct 15, 2019
Converted them into paragraphs' headers instead, hope it's ok
@akasma74
Copy link
Copy Markdown
Contributor Author

Rebased and comverted extra tags into paragraphs' headers, please check it out.

@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 15, 2019

Hi there @akasma74,

I don't see a rebase, the only thing I see is that you've changed the target branch. Could you please rebase the PR's onto the current branch as well?

Feel free to ask if you need any help with that.

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Oct 15, 2019
@akasma74
Copy link
Copy Markdown
Contributor Author

akasma74 commented Oct 15, 2019

Hi @frenck , tbh I don't know how to rebase PRs so any help is highly appreciated.

Update: I ended up creating a new PR to the current branch to speed up things.
Still happy to learn how to rebase a PR onto the current branch.

akasma74 added a commit to akasma74/home-assistant.io that referenced this pull request Oct 16, 2019
This PR superceeds home-assistant#10796 (couldn't rebase that).
I couldn't find anything in the current docs on time formats and thought it would be useful to give more details (rather than time | integer description) about ones available.
@akasma74 akasma74 mentioned this pull request Oct 16, 2019
2 tasks
@akasma74 akasma74 closed this Oct 16, 2019
@probot-home-assistant probot-home-assistant Bot added Invalid and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 16, 2019
@akasma74 akasma74 deleted the patch-14 branch October 16, 2019 15:00
@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 16, 2019

Thanks for creating a new PR, however, you didn't have to. I would have rebased it for you....
But yeah, this works I guess. 🤷‍♂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch Invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.