Skip to content

Clarification of time formats#10820

Merged
frenck merged 4 commits into
home-assistant:currentfrom
akasma74:patch-15
Oct 17, 2019
Merged

Clarification of time formats#10820
frenck merged 4 commits into
home-assistant:currentfrom
akasma74:patch-15

Conversation

@akasma74
Copy link
Copy Markdown
Contributor

This PR superceeds #10796 (couldn't rebase that).
I couldn't find anything in the current docs on time formats and thought it would be useful to give more details (rather than time | integer description) about ones available.

Description:

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

This PR superceeds home-assistant#10796 (couldn't rebase that).
I couldn't find anything in the current docs on time formats and thought it would be useful to give more details (rather than time | integer description) about ones available.
@probot-home-assistant probot-home-assistant Bot added current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 16, 2019
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @akasma74, thanks for the PR!

I've reviewed it and left some comments, could you please take a look? Thanks! 👍

Comment thread source/_integrations/generic_thermostat.markdown
Comment thread source/_integrations/generic_thermostat.markdown Outdated
Comment thread source/_integrations/generic_thermostat.markdown Outdated
Comment thread source/_integrations/generic_thermostat.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Oct 16, 2019
akasma74 and others added 2 commits October 16, 2019 23:09
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Hope it looks better now
@akasma74
Copy link
Copy Markdown
Contributor Author

@frenck I've made some changes, hope it's better now.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @akasma74! 👍

Happy Hacktoberfest 🎉

@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Oct 17, 2019
@akasma74
Copy link
Copy Markdown
Contributor Author

Thanks for approving the PR.
BTW, I was always curious why there is no mention of services to work with generic_thermostat on this page (and tbh it's not that obvious where to look for them) - perhaps it's a good idea to add something like this before the config exapmple?

For the services available to work with generic_thermostat entities please refer to this page.

Shall I add it to this PR or it's better to create a separate one (I support the former, reflecting this in PR's title)?

@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 17, 2019

We are looking for more generic ways to resolve this. Since every entity has one of the core entities as the base (e.g., light, climate, switch), and thus inherits the services. Adding this to every single integration or platform seems a bit cumbersome 😉

@frenck frenck merged commit 08ecca7 into home-assistant:current Oct 17, 2019
@akasma74
Copy link
Copy Markdown
Contributor Author

Agree, the more generic way would be ideal.
Just wanted to check that you guys have it on your list as currently it's a bit difficult to use for some and definitely can be improved ;)

@akasma74 akasma74 deleted the patch-15 branch October 17, 2019 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants