Skip to content

Neato config flow#10356

Merged
frenck merged 2 commits into
home-assistant:nextfrom
Santobert:neato_config_flow
Oct 6, 2019
Merged

Neato config flow#10356
frenck merged 2 commits into
home-assistant:nextfrom
Santobert:neato_config_flow

Conversation

@Santobert
Copy link
Copy Markdown
Member

Description:
Update the documentation according to the recently changed configuration process of neato integration.

Pull request in home-assistant (if applicable): home-assistant/core#26579

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Sep 13, 2019
Copy link
Copy Markdown
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change for readability

Comment thread source/_components/neato.markdown Outdated
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Sep 13, 2019
frenck
frenck previously approved these changes Sep 13, 2019
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Sep 13, 2019
@Santobert Santobert requested a review from frenck October 4, 2019 10:06
@Santobert
Copy link
Copy Markdown
Member Author

@frenck I just had some problems with merging... no content was changed

frenck
frenck previously approved these changes Oct 4, 2019
@probot-home-assistant probot-home-assistant Bot added the parent-merged The parent PR has been merged already label Oct 6, 2019
@MartinHjelmare MartinHjelmare removed the awaits-parent Awaits the merge of an parent PR label Oct 6, 2019
MartinHjelmare
MartinHjelmare previously approved these changes Oct 6, 2019
@klaasnicolaas
Copy link
Copy Markdown
Member

missing the ha_config_flow: true at the top 😄

@Santobert Santobert dismissed stale reviews from MartinHjelmare and frenck via 1440ae1 October 6, 2019 11:52
@Santobert
Copy link
Copy Markdown
Member Author

missing the ha_config_flow: true at the top smile

Added that. Is it correct?

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Santobert! That looks good now! 👍

@frenck frenck merged commit ac0d298 into home-assistant:next Oct 6, 2019
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Oct 6, 2019
@Santobert Santobert deleted the neato_config_flow branch October 19, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants