Skip to content

Add documentation about new key: time_format#10463

Merged
frenck merged 4 commits into
home-assistant:nextfrom
tsvi:patch-1
Oct 10, 2019
Merged

Add documentation about new key: time_format#10463
frenck merged 4 commits into
home-assistant:nextfrom
tsvi:patch-1

Conversation

@tsvi
Copy link
Copy Markdown
Contributor

@tsvi tsvi commented Sep 26, 2019

Based on PR home-assistant/home-asssitant#26940 this adds athe documentation about the new key + a warning on relying to much on the time based sensors.

Description:

Pull request in home-assistant (if applicable): home-assistant/core#26940

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Sep 26, 2019
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed labels Sep 27, 2019
@klaasnicolaas klaasnicolaas added the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Oct 6, 2019
@klaasnicolaas
Copy link
Copy Markdown
Member

Can you resolve the merge conflict?

frenck
frenck previously approved these changes Oct 6, 2019
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch ready-for-review This PR needs to be reviewed labels Oct 6, 2019
@probot-home-assistant probot-home-assistant Bot removed the awaits-parent Awaits the merge of an parent PR label Oct 7, 2019
@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Oct 7, 2019
tsvi added 4 commits October 10, 2019 19:29
Based on PR home-assistant/home-asssitant#26940 this adds athe documentation about the new key + a warning on relying to much on the time based sensors.
@probot-home-assistant probot-home-assistant Bot added the parent-merged The parent PR has been merged already label Oct 10, 2019
@frenck frenck merged commit 376d317 into home-assistant:next Oct 10, 2019
@probot-home-assistant probot-home-assistant Bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Oct 10, 2019
@tsvi tsvi deleted the patch-1 branch October 10, 2019 19:36
@tsvi tsvi restored the patch-1 branch October 10, 2019 19:50
@tsvi tsvi deleted the patch-1 branch May 23, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants