Skip to content

Add support for service translations#95984

Merged
frenck merged 11 commits into
devfrom
frenck-2023-0938
Jul 11, 2023
Merged

Add support for service translations#95984
frenck merged 11 commits into
devfrom
frenck-2023-0938

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Jul 6, 2023

Proposed change

This PR adds basic support for the translations of services.

I've picked light to be the first one for this use case, as it is bigger and contains all permutations we need to support.

hassfest has been adjusted to both verify the translation schema, as well as the validation of the services, which takes the translations into account.

This PR also makes name of both the service and the service fields required.

TODO:

  • Frontend
  • Handling/structure for selector translations (e.g. values of a select selector).
  • Backwards compatibility (for e.g, Node-Red, Appdaemon and others)
  • Update developer documentation
  • Write dev blog on the change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 6, 2023

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (light) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of light can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign light Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@frenck
Copy link
Copy Markdown
Member Author

frenck commented Jul 8, 2023

Rebased to deal with a merge conflict (and more "name" cases in current dev should be solved).

@frenck frenck force-pushed the frenck-2023-0938 branch from 4b1f9ca to 8be73b6 Compare July 10, 2023 09:02
@frenck
Copy link
Copy Markdown
Member Author

frenck commented Jul 10, 2023

Backwards compatibility also working now

CleanShot 2023-07-10 at 21 54 19

(☝️ current PR with the frontend of the 2023.8.1 release)

@frenck frenck marked this pull request as ready for review July 10, 2023 20:35
@frenck frenck requested a review from a team as a code owner July 10, 2023 20:35
Comment thread homeassistant/components/light/strings.json Outdated
This was referenced Jul 11, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed core integration: light new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants