Translatable service names and descriptions#95977
Closed
jpbede wants to merge 3 commits into
Closed
Conversation
Member
|
Wow, I'm actually working on this too for the upcoming release. But the approach is different. I've just got out of meeting with Bram & Paul (frontend, 5 minutes ago), and discussed a few things on this. The approach we are want to take is handle this from the frontend (just like we do with all other translations) and not from the backend. We do not need to keep this in the backend at all. ../Frenck |
Member
Author
|
Alright, then I'm going to close this :) |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR introduces translations for the service name and description. In a later PR, I'll add translations for the field names and descriptions if this is something that is desired.
This does not introduce breaking changes or anything. If there is no translation, it will fall back to the one defined in
services.yaml.TODO: currently missing tests
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: