Skip to content

Migrate tts services to support translations#96412

Merged
frenck merged 5 commits into
devfrom
frenck-2023-1037
Jul 12, 2023
Merged

Migrate tts services to support translations#96412
frenck merged 5 commits into
devfrom
frenck-2023-1037

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Jul 12, 2023

Proposed change

Migrates the tts-provided services to support translated services.

More information, see: #95984

ℹ️ The contents of this PR has been scripted and migrated from source automatically. Afterward, tweaked it for consistency and used references.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @home-assistant/core, @pvizeli, mind taking a look at this pull request as it has been labeled with an integration (tts) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tts can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tts Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Comment thread homeassistant/components/tts/strings.json Outdated
Comment thread homeassistant/components/tts/strings.json Outdated
Comment thread homeassistant/components/tts/strings.json Outdated
Comment thread homeassistant/components/tts/strings.json Outdated
Comment thread homeassistant/components/tts/strings.json Outdated
Comment thread homeassistant/components/tts/strings.json Outdated
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
@frenck frenck requested a review from c0ffeeca7 July 12, 2023 13:54
Comment thread homeassistant/components/tts/strings.json Outdated
frenck and others added 2 commits July 12, 2023 16:09
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
@frenck frenck requested a review from c0ffeeca7 July 12, 2023 14:09
Comment thread homeassistant/components/tts/strings.json Outdated
Copy link
Copy Markdown
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix typo

@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft July 12, 2023 14:11
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
@frenck frenck requested a review from c0ffeeca7 July 12, 2023 14:43
@frenck frenck marked this pull request as ready for review July 12, 2023 15:00
@home-assistant home-assistant Bot requested a review from c0ffeeca7 July 12, 2023 15:00
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 12, 2023
@frenck frenck merged commit 021aaa9 into dev Jul 12, 2023
@frenck frenck deleted the frenck-2023-1037 branch July 12, 2023 16:55
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed core integration: tts new-feature Quality Scale: internal smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants