Skip to content

Migrate homeassistant services to support translations#96388

Merged
frenck merged 2 commits into
devfrom
frenck-2023-1017
Jul 12, 2023
Merged

Migrate homeassistant services to support translations#96388
frenck merged 2 commits into
devfrom
frenck-2023-1017

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Jul 12, 2023

Proposed change

Migrates the homeassistant-provided services to support translated services.

More information, see: #95984

ℹ️ The contents of this PR has been scripted and migrated from source automatically. Afterward, tweaked it for consistency and used references.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (homeassistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homeassistant can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homeassistant Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@frenck frenck requested a review from c0ffeeca7 July 12, 2023 07:00
Comment thread homeassistant/components/homeassistant/strings.json Outdated
Comment thread homeassistant/components/homeassistant/strings.json Outdated
Comment thread homeassistant/components/homeassistant/strings.json Outdated
},
"save_persistent_states": {
"name": "Save persistent states",
"description": "Saves the persistent states immediately. Maintains the normal periodic saving interval."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Saves the persistent states immediately. Maintains the normal periodic saving interval."
"description": "Saves the persistent states immediately. Maintains the normal periodic saving interval."

What is this used for? Why would I enable this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't enabling anything, it trigger a save to disk of the states immediately. Normally, this runs on a schedule / interval. This service allows you to request one now, instead awaiting the next interval to hit.

The interval isn't interrupted or changed, it will continue. So this is an extra way to force a save of states right now.

This is not something regular users use, but because HA saves every X seconds, it means that if HA crashes, it could loose X seconds of data that wasn't saved yet. This allows an user to force a save right now, in case they have received state data they want to secure to disk as soon as possible.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, it's like a save button. Thank you for explaining.

Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
@frenck frenck requested a review from c0ffeeca7 July 12, 2023 07:30
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 12, 2023
@frenck frenck merged commit ce5246a into dev Jul 12, 2023
@frenck frenck deleted the frenck-2023-1017 branch July 12, 2023 11:47
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants