Skip to content

Skip db locking test with postgresql/MySQL#87760

Merged
epenet merged 3 commits into
home-assistant:devfrom
bdraco:no_lock_db_pgsql
Feb 9, 2023
Merged

Skip db locking test with postgresql/MySQL#87760
epenet merged 3 commits into
home-assistant:devfrom
bdraco:no_lock_db_pgsql

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Feb 9, 2023

Proposed change

#87756 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 9, 2023

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of recorder can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign recorder Removes the current integration label and assignees on the issue, add the integration domain after the command.

@epenet epenet mentioned this pull request Feb 9, 2023
19 tasks
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of running MariaDB + PostgreSQL tests with an SQlite database, do this to exit the tests early:

    if recorder_db_url.startswith(("mysql://", "postgresql://")):
        # Database locking is only used for SQLite
        return

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 9, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@bdraco bdraco requested a review from emontnemery February 9, 2023 09:14
@epenet epenet added the ci-full-run Marks a PR to trigger a full CI run (instead of partial) label Feb 9, 2023
@epenet epenet closed this Feb 9, 2023
@epenet epenet reopened this Feb 9, 2023
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Feb 9, 2023

MariaDB test is still expected to timeout but should be fixed in #87765

@epenet epenet removed the ci-full-run Marks a PR to trigger a full CI run (instead of partial) label Feb 9, 2023
@bdraco bdraco closed this Feb 9, 2023
@emontnemery emontnemery reopened this Feb 9, 2023
@emontnemery
Copy link
Copy Markdown
Contributor

Let's merge this to unblock CI. Then we have more time to implement a proper fix of the bad tests 👍

@epenet
Copy link
Copy Markdown
Contributor

epenet commented Feb 9, 2023

I'm going to merge this.
It doesn't solve all the CI issues, but will help to expose the remaining ones.

@epenet epenet merged commit 483b0cd into home-assistant:dev Feb 9, 2023
AlePerla pushed a commit to AlePerla/homeassistant_core that referenced this pull request Feb 10, 2023
* Skip db locking test with postgresql/MySQL

home-assistant#87756 (comment)

* switch to the guards instead
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants