Add mariadb 10.3.32 to database tests#87741
Conversation
bebe1e5 to
82119bd
Compare
|
CI is failing - will need to be rebased after #87760 |
|
They wouldn't have run before either the CI changes. You can add a label "ci-full-run" to trigger full suite. Edit: fixed in #87764 |
82119bd to
f8c0a44
Compare
|
We might have fixed it. Merged in dev to get a clean run. If it still fails on 10.3.x I'll need to dig more once everything else is cleaned up |
|
Still failing Thats a bit concerning as it implies it affects production |
|
🤞 that the latest round of fixes take care of this. Otherwise its a deep dive with 10.3.x |
|
Good news it it actually looks like a race and the new event is being recorded while the test is running |
|
Looks like it isn't the problem I thought it was. Running out of steam though to dig into this more so may have to be tomorrow |
|
Still haven't figured out what is going on here. Will try again after sleep |
|
Adding 10.3 might not be worth the effort since it goes eol in 3 months and 1 week However I'm torn since there will probably still be a lot of synology users using it so it might still be worth it |
|
I want to additional MySQL tests going and than will come back to this. |
|
Sure thing - I just resolved the conflict with #87989 and adjusted the PR title/description. |
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Fails locally with the above |
|
|
This test is actually testing the wrong thing. There shouldn't be any event datas in this test. 🤦 |
|
Merging in dev to make sure the new set of MariaDB tests also pass that I just merged |
Proposed change
10.3.32(oldest supported version) to ensure more code branches are coveredcc @bdraco
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: