Skip to content

Ensure MySQL tests cleanup connections and raise an exception if they do not#87767

Merged
bdraco merged 42 commits into
home-assistant:devfrom
bdraco:ii
Feb 9, 2023
Merged

Ensure MySQL tests cleanup connections and raise an exception if they do not#87767
bdraco merged 42 commits into
home-assistant:devfrom
bdraco:ii

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Feb 9, 2023 •
edited
Loading

Proposed change

Fixes a few tests not cleaning up connections.

We now raise an exception when a test fails to fully cleanup.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

bdraco added 8 commits February 9, 2023 02:54
@bdraco
Skip db locking test with postgresql/MySQL
342ee3a 
home-assistant#87756 (comment)
@bdraco
Turn back off test_shutdown_before_startup_finishes on MySQL
dc3a7b3 
Was just enabled in home-assistant#87756 (comment)
but not yet ready as it is still failing on the CI
@bdraco
switch to the guards instead
0005e89
@bdraco
Merge branch 'test_shutdown_before_startup_finishes_mysql' into ii
57e16da
@bdraco
Disable test_migration_in_progress on MySQL
30c3637 
This test was recently enabled on MySQL in
home-assistant#87753

Since it the migration is still in progress in the background
when the test ends, it causes deadlock with InnoDB when its dropped
out from under it
@bdraco
Merge branch 'disable_test_migration_in_progress' into ii
3d3310e
@bdraco
Disable test_entity_ids on MariaDB
d6d5848 
Dropping the database after this test will fail on
MySQL and hang forever because it causes an InnoDB deadlock

```
| 2042 | root   | localhost:52698 | NULL               | Query   |   41 | Waiting for table metadata lock | DROP DATABASE `homeassistant-test` |    0.000 |
```
@bdraco
Merge branch 'test_entity_ids_innodb_deadlock' into ii
a3ddbe2
@bdraco bdraco requested a review from a team as a code owner February 9, 2023 09:40
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 9, 2023

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of recorder can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign recorder Removes the current integration label and assignees on the issue, add the integration domain after the command.

@bdraco bdraco changed the title Fix database test in the CI Fix database tests in the CI Feb 9, 2023
epenet
epenet approved these changes Feb 9, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, LGTM 👍
cc @emontnemery

bdraco
bdraco commented Feb 9, 2023
View reviewed changes
Comment thread tests/components/recorder/test_init.py
emontnemery
emontnemery requested changes Feb 9, 2023
View reviewed changes
Comment thread tests/conftest.py Outdated
@home-assistant home-assistant Bot marked this pull request as draft February 9, 2023 10:19
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 9, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@epenet epenet mentioned this pull request Feb 9, 2023
Merged
19 tasks
@epenet
Copy link
Copy Markdown
Contributor

epenet commented Feb 9, 2023

#87760 was merged, triggering fresh run now.

@epenet epenet mentioned this pull request Feb 9, 2023
Merged
19 tasks
@bdraco bdraco changed the title Fix database tests in the CI Raise an exception if the MySQL connection is still open when cleaning up tests Feb 9, 2023
@bdraco bdraco marked this pull request as ready for review February 9, 2023 17:59
@bdraco bdraco requested a review from emontnemery February 9, 2023 18:00
@bdraco bdraco changed the title Raise an exception if the MySQL connection is still open when cleaning up tests Ensure MySQL tests cleanup connections and raise an exception if the MySQL connection if they do not Feb 9, 2023
@bdraco bdraco changed the title Ensure MySQL tests cleanup connections and raise an exception if the MySQL connection if they do not Ensure MySQL tests cleanup connections and raise an exception if they do not Feb 9, 2023
emontnemery
emontnemery approved these changes Feb 9, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bdraco bdraco marked this pull request as draft February 9, 2023 18:55
bdraco
bdraco commented Feb 9, 2023
View reviewed changes
Comment thread tests/components/recorder/test_init.py
@bdraco bdraco marked this pull request as ready for review February 9, 2023 21:13
@home-assistant home-assistant Bot requested a review from emontnemery February 9, 2023 21:14
@bdraco bdraco merged commit cbaf476 into home-assistant:dev Feb 9, 2023
@bdraco bdraco deleted the ii branch February 9, 2023 22:27
AlePerla pushed a commit to AlePerla/homeassistant_core that referenced this pull request Feb 10, 2023
@bdraco @epenet
@emontnemery @AlePerla
Ensure MySQL tests cleanup connections and raise an exception if they…
6c55abb 
… do not (home-assistant#87767)

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: Erik <erik@montnemery.com>
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@epenet epenet epenet approved these changes

@emontnemery emontnemery Awaiting requested review from emontnemery

Assignees

No one assigned

Labels

cla-signed core has-tests integration: recorder Quality Scale: internal small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bdraco @epenet @emontnemery