Disable test_migration_in_progress on MySQL#87765
Merged
emontnemery merged 1 commit intoFeb 9, 2023
Merged
Conversation
This test was recently enabled on MySQL in home-assistant#87753 Since it the migration is still in progress in the background when the test ends, it causes deadlock with InnoDB when its dropped out from under it
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
19 tasks
Member
Author
|
MariaDB/Postgresql locking test will fail but should be fixed in #87760 |
Member
Author
|
There is yet another MariaDB InnoDB metadata deadlock somewhere. That sure is buggy |
19 tasks
Contributor
|
Let's merge this to unblock CI. Then we have more time to implement a proper fix of the bad tests 👍 |
emontnemery
approved these changes
Feb 9, 2023
Contributor
|
I'll merge this since it disables a bad test. The remaining bad test will be fixed in a follow up |
AlePerla
pushed a commit
to AlePerla/homeassistant_core
that referenced
this pull request
Feb 10, 2023
This test was recently enabled on MySQL in home-assistant#87753 Since it the migration is still in progress in the background when the test ends, it causes deadlock with InnoDB when its dropped out from under it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This test was recently enabled on MySQL in
#87753
Since the post migration is still in progress in the background when the test ends, it causes deadlock with InnoDB when its dropped out from under it
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: