Skip to content

Ensure recorder still shuts down if the final commit fails#87799

Merged
bdraco merged 4 commits into
home-assistant:devfrom
bdraco:ensure_recorder_shutdown
Feb 9, 2023
Merged

Ensure recorder still shuts down if the final commit fails#87799
bdraco merged 4 commits into
home-assistant:devfrom
bdraco:ensure_recorder_shutdown

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Feb 9, 2023

Proposed change

If the final commit in _end_session raised, we would never close the event session which would leave the connection open leading to an unclean shutdown.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

If the final commit in _end_session raised, we would
never close the event session which would leave the
connection open leading to an unclean shutdown
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 9, 2023

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of recorder can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign recorder Removes the current integration label and assignees on the issue, add the integration domain after the command.

@bdraco bdraco marked this pull request as ready for review February 9, 2023 19:29
@bdraco bdraco requested a review from a team as a code owner February 9, 2023 19:29
Comment thread homeassistant/components/recorder/core.py Outdated
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Feb 9, 2023

Going to get this chain merged, than rebase #87741 and see if it still fails.

If it does I'll start looking into that one.

@bdraco bdraco merged commit 509de02 into home-assistant:dev Feb 9, 2023
@bdraco bdraco deleted the ensure_recorder_shutdown branch February 9, 2023 21:12
AlePerla pushed a commit to AlePerla/homeassistant_core that referenced this pull request Feb 10, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants