Skip to content

Add recorder engine name and version to analytics#87784

Merged
ludeeus merged 6 commits into
devfrom
analytics-recorder
Feb 13, 2023
Merged

Add recorder engine name and version to analytics#87784
ludeeus merged 6 commits into
devfrom
analytics-recorder

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Feb 9, 2023

Proposed change

For those who have chosen to share their usage data, we're now extending our analytics integration to include the name and version of your configured database.

Requires home-assistant/analytics.home-assistant.io#688

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@ludeeus ludeeus added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Feb 9, 2023
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 9, 2023

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (analytics) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of analytics can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign analytics Removes the current integration label and assignees on the issue, add the integration domain after the command.

@ludeeus ludeeus changed the title Analytics recorder Add recorder engine name to analytics Feb 9, 2023
@epenet
Copy link
Copy Markdown
Contributor

epenet commented Feb 9, 2023

I wonder: should we also have the engine version? see #87741

Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I agree we should consider adding the engine version too

@ludeeus ludeeus changed the title Add recorder engine name to analytics Add recorder engine name and version to analytics Feb 13, 2023
@ludeeus ludeeus marked this pull request as ready for review February 13, 2023 08:10
@ludeeus ludeeus requested a review from a team as a code owner February 13, 2023 08:10
@ludeeus ludeeus merged commit e842f90 into dev Feb 13, 2023
@ludeeus ludeeus deleted the analytics-recorder branch February 13, 2023 08:18
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed has-tests integration: analytics new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: internal small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants