Add support for zwave_js controller firmware updates#15515
Conversation
| ]; | ||
| const actions: DeviceAction[] = []; | ||
|
|
||
| if (!nodeStatus.is_controller_node) { |
There was a problem hiding this comment.
Why this extra if, if we are only adding actions when not is_controller_node
There was a problem hiding this comment.
we are adding actions if there is a controller node just for the firmware update but all of these actions come before the firmware update action in the list
There was a problem hiding this comment.
is this possibly the confusing part because I moved the not operator outside of each individual check? I can move it back inside so each individual statement is easier to understand: https://github.com/home-assistant/frontend/pull/15515/files#diff-4834eb73ab93f8dfa87c03847b42ab8539d6b51909e48038a784dc80d08e2472R103-R106
|
@kpine tested all three PRs E2E and everything looks functional! |
|
Demo (file selection dialog omitted for privacy): chrome_uRgy2A6IrN.mp4Notice the version changes from 7.18.1 to 7.18.2 at the end. |
raman325
force-pushed
the
controller_firmware
branch
from
294eebc to
95d021b
Compare
|
FYI I created some new strings for controller specific text, moved some stuff out of render that doesnt need to be there, and rebased. The result of the changes are in @kpine 's comment |
3 participants
Proposed change
Adds support for manual zwave_js controller firmware updates in the UI. Depends on the following PRs:
zwave_js/subscribe_firmware_update_statuscore#87348Will move this out of draft when the ready PRs are merged as it will likely require a merge conflict fix before this can be used and requires some additional logic to handle this #15517 as the controller node should not have this option in this UI
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: