Weather units: accuweather (1.0 / 4)#61469
Closed
rianadon wants to merge 3 commits intohome-assistant:devfrom
Closed
Weather units: accuweather (1.0 / 4)#61469rianadon wants to merge 3 commits intohome-assistant:devfrom
rianadon wants to merge 3 commits intohome-assistant:devfrom
Conversation
|
Hey there @bieniu, mind taking a look at this pull request as it has been labeled with an integration ( |
22 tasks
Member
|
This is a massive breaking change. Also:
|
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Uses the new weather conversion in the weather entity ( #59533) to convert weather values to the configured units.
This particular PR involves some extra work to parse the units Accuweather gives. They might give back some speeds in knots, so I've added a SPEED_KNOTS to the list of constants and conversion functions.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: