Skip to content

Weather units: accuweather (1.0 / 4)#61469

Closed
rianadon wants to merge 3 commits intohome-assistant:devfrom
rianadon:weather-units-accuweather
Closed

Weather units: accuweather (1.0 / 4)#61469
rianadon wants to merge 3 commits intohome-assistant:devfrom
rianadon:weather-units-accuweather

Conversation

@rianadon
Copy link
Copy Markdown
Contributor

Proposed change

Uses the new weather conversion in the weather entity ( #59533) to convert weather values to the configured units.

This particular PR involves some extra work to parse the units Accuweather gives. They might give back some speeds in knots, so I've added a SPEED_KNOTS to the list of constants and conversion functions.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @bieniu, mind taking a look at this pull request as it has been labeled with an integration (accuweather) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@rianadon rianadon marked this pull request as draft December 11, 2021 10:51
@rianadon rianadon marked this pull request as ready for review December 17, 2021 04:27
@frenck
Copy link
Copy Markdown
Member

frenck commented Jan 10, 2022

This is a massive breaking change.

Also:

@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 10, 2022
@github-actions github-actions bot closed this Apr 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants