Skip to content

Weather units: Buienradar (1.2/4)#61470

Merged
frenck merged 1 commit intohome-assistant:devfrom
rianadon:weather-units-buienradar
Jan 7, 2022
Merged

Weather units: Buienradar (1.2/4)#61470
frenck merged 1 commit intohome-assistant:devfrom
rianadon:weather-units-buienradar

Conversation

@rianadon
Copy link
Copy Markdown
Contributor

Proposed change

Uses the new weather conversion in the weather entity ( #59533) to convert weather values to the configured units.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @mjj4791, @ties, @RobBie1221, mind taking a look at this pull request as it has been labeled with an integration (buienradar) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@rianadon rianadon changed the title Weather units: Buienradar (1.1/4) Weather units: Buienradar (1.2/4) Dec 11, 2021
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jan 4, 2022
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rianadon 👍

@frenck frenck merged commit b5d55ce into home-assistant:dev Jan 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality integration: buienradar small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants