Skip to content

Weather units: accu to climacell (1/4)#60828

Closed
rianadon wants to merge 3 commits intohome-assistant:devfrom
rianadon:weather-units-accu-to-climacell
Closed

Weather units: accu to climacell (1/4)#60828
rianadon wants to merge 3 commits intohome-assistant:devfrom
rianadon:weather-units-accu-to-climacell

Conversation

@rianadon
Copy link
Copy Markdown
Contributor

@rianadon rianadon commented Dec 2, 2021

Proposed change

Uses the new weather conversion in the weather entity ( #59533) to convert weather values to the configured units.

This particular PR involves some extra work to parse the units Accuweather gives. They might give back some speeds in knots, so I've added a SPEED_KNOTS to the list of constants and conversion functions.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @bieniu, mind taking a look at this pull request as it has been labeled with an integration (accuweather) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant probot-home-assistant bot assigned raman325 and unassigned raman325 Dec 2, 2021
@probot-home-assistant
Copy link
Copy Markdown

Hey there @raman325, mind taking a look at this pull request as it has been labeled with an integration (climacell) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Noltari, mind taking a look at this pull request as it has been labeled with an integration (aemet) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @mjj4791, @ties, @RobBie1221, mind taking a look at this pull request as it has been labeled with an integration (buienradar) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@epenet
Copy link
Copy Markdown
Contributor

epenet commented Dec 2, 2021

I suggest that you do one integration at a time.
It makes reviewing easier, and if you get comments for one integration you can easily update the other integrations.

The changes on each integration are more than just a single line of code... and with the new CI implementation it won't starve HA of build agents.

@rianadon
Copy link
Copy Markdown
Contributor Author

@rianadon rianadon closed this Dec 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants