Revert "Weather units: climacell (1.3/4)"#63842
Merged
Conversation
This reverts commit 48057e1.
|
Hey there @raman325, mind taking a look at this pull request as it has been labeled with an integration ( |
This was referenced Jan 10, 2022
raman325
approved these changes
Jan 11, 2022
Member
Author
|
Update PR description to make intention more clear; as I do think this feature is a good idea in general. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #61472
I'm suggesting to revert this case.
It is a massive breaking change and not tagged or documented as such.
Additionally, it makes the core configuration responsible for configuring units in this place, while the magnitude of those units should probably not be centralized.
Some more context is here as well: home-assistant/architecture#682
However, this merged PR already was merged and went ahead before that all was taken into consideration.
CC: @emontnemery @rianadon
PS: I want to add to this: I do think in general the idea of this change and the feature is correct. As a matter of fact, I hope to see something like this on a bigger scale (e.g., being able to change the scale of, or convert between units of measurements on maybe even entity level!). This is an important step forward for that.
However, currently, it relies on the core configuration as the sole determination for the units used. The latter should be discussed and crystallized more (with the future in mind) before we start making breaking changes.