Skip to content

Update xknx to 0.15.3#42026

Merged
balloob merged 3 commits intohome-assistant:devfrom
marvin-w:xknx-0.15.2
Nov 13, 2020
Merged

Update xknx to 0.15.3#42026
balloob merged 3 commits intohome-assistant:devfrom
marvin-w:xknx-0.15.2

Conversation

@marvin-w
Copy link
Copy Markdown
Contributor

@marvin-w marvin-w commented Oct 18, 2020

Breaking change

The parameter context_timeout is now optional for binary sensors and will default to None. If you've previously not specified this parameter you'll have to adjust your config and add it like this:

knx:
  binary_sensor:
    - name: sensor
      state_address: "1/2/3"
      context_timeout: 1.0

This prevents users that do not use this feature from waiting one second until automations are triggered.

The parameter reset_after for binary sensors expects seconds now instead of milliseconds to streamline the different configuration options. (context_timeout also uses seconds)

The parameter ignore_internal_state for binary sensors now defaults to False as most users do not use this feature. It defaulted to True before.

If you have validation errors of your config after the update and you are using the operation_modes parameter for your climate devices please add all erroneous entries to the new controller_modes parameter.

Proposed change

Updates the underlying library to 0.15.3.
https://github.com/XKNX/xknx/releases/tag/0.15.1
https://github.com/XKNX/xknx/releases/tag/0.15.2
https://github.com/XKNX/xknx/releases/tag/0.15.3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Julius2342, @farmio, mind taking a look at this pull request as its been labeled with an integration (knx) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@farmio
Copy link
Copy Markdown
Member

farmio commented Oct 21, 2020

This update also adds

  • reset_after option for Switches
  • always_callback option for Sensors

and should fix

  • problems with the StateUpdater. It previously queried to aggressive so the connection to some installations could not be made reliably.
  • Climate reporting wrong mode

@sagitt
Copy link
Copy Markdown

sagitt commented Oct 28, 2020

will be in 0.117.x?

@farmio
Copy link
Copy Markdown
Member

farmio commented Oct 28, 2020

No. 0.117 will be released today, this is not even merged to dev currently.

@sagitt
Copy link
Copy Markdown

sagitt commented Nov 1, 2020

No. 0.117 will be released today, this is not even merged to dev currently.

thanks. i hope in 0.118... with new 0.15.3. the only way to use my knx setup now is restart home assistant every hour.

@marvin-w marvin-w changed the title Update xknx to 0.15.2 Update xknx to 0.15.3 Nov 6, 2020
Copy link
Copy Markdown
Member

@farmio farmio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review shall help HA reviewers get a picture of what we did here.

Comment thread homeassistant/components/knx/climate.py Outdated
Comment thread homeassistant/components/knx/factory.py Outdated
Comment thread homeassistant/components/knx/factory.py Outdated
Comment thread homeassistant/components/knx/factory.py Outdated
Comment thread homeassistant/components/knx/factory.py Outdated
Comment thread homeassistant/components/knx/manifest.json Outdated
@sagitt

This comment has been minimized.

Comment thread homeassistant/components/knx/climate.py Outdated
Comment thread homeassistant/components/knx/schema.py Outdated
Comment thread homeassistant/components/knx/schema.py Outdated
Marvin Wichmann and others added 3 commits November 12, 2020 23:47
@marvin-w
Copy link
Copy Markdown
Contributor Author

I integrated all review comments and rebased again against current dev.

@balloob balloob added this to the 0.118.0 milestone Nov 13, 2020
@balloob balloob merged commit 899fc3d into home-assistant:dev Nov 13, 2020
@marvin-w marvin-w deleted the xknx-0.15.2 branch November 13, 2020 08:45
@marvin-w
Copy link
Copy Markdown
Contributor Author

Thanks @balloob <3

balloob added a commit that referenced this pull request Nov 13, 2020
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
KJonline pushed a commit to Pyhass/core that referenced this pull request Nov 13, 2020
* 'dev' of https://github.com/home-assistant/core: (32 commits)
  Disable parsing scientific/complex number notation in template type (home-assistant#43170)
  Remove relative time sensor from cert_expiry (home-assistant#42338)
  Further improve MFI tests (home-assistant#43167)
  Update translations
  Guard against empty ssdp locations (home-assistant#43156)
  Fix playing of Spotify URIs on Sonos (home-assistant#43154)
  Add missing 'hassio' translation string (home-assistant#43127)
  Streamline SimpliSafe errors (home-assistant#43117)
  Update xknx to 0.15.3 (home-assistant#42026)
  Fix beat calculation (home-assistant#43142)
  Mock time_date sensor tests (home-assistant#43141)
  [ci skip] Translation update
  Fix bug preventing Notion entities from updating their bridge (home-assistant#43122)
  Bump hass-nabucasa to 0.37.2 (home-assistant#43146)
  Shelly: minor improvements (home-assistant#43138)
  Add support for learning RF commands with Broadlink remotes (home-assistant#39671)
  Fix incorrect Notion battery state calculation (home-assistant#43108)
  Bump hatasmota to 0.0.30 (home-assistant#43140)
  Add VSCode debug launch conf (home-assistant#43130)
  Revert "shelly_naming" rebase errors (home-assistant#43134)
  ...
@SquaredCircleHunter
Copy link
Copy Markdown

SquaredCircleHunter commented Nov 19, 2020

From https://www.home-assistant.io/blog/2020/11/18/release-118/#breaking-changes

The parameter context_timeout is now optional for binary sensors and will default to None. If you’ve previously not specified this parameter you’ll have to adjust your configuration and add it like this: "context_timeout: 1.0". This prevents users that do not use this feature from waiting one second until automations are triggered.

I've read it 3 times, but it confuses me. I would think that if you do not specify anything, you will get context_timeout defaulted to None and thus no delay? And if you set it to 1.0, you will get the delay?

@marvin-w
Copy link
Copy Markdown
Contributor Author

Exactly.

@sagitt
Copy link
Copy Markdown

sagitt commented Nov 19, 2020

yesterday the official documentation are note updated to new 118 configurations

@SquaredCircleHunter
Copy link
Copy Markdown

Ok, so I don't need to change anything to me pre-118 config? What was the default value before?

I already had binary sensors where it was not defined, so it was already optional.

@marvin-w
Copy link
Copy Markdown
Contributor Author

The default before was 1.0. So you don't need to do anything.

@cg089
Copy link
Copy Markdown

cg089 commented Nov 19, 2020

After Updating to 0.118.0, the status of all switches show "off" (most of them are on). The status is not updated.
The status of the lights is correct, however. I don't use context_timeout neither in light nor in switch.

@marvin-w
Copy link
Copy Markdown
Contributor Author

Please open an issue instead of commenting into this merged pull request.

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.