Skip to content

Update xknx to 0.15.3#15301

Merged
frenck merged 5 commits into
home-assistant:currentfrom
marvin-w:update-xknx-to-15.2
Nov 19, 2020
Merged

Update xknx to 0.15.3#15301
frenck merged 5 commits into
home-assistant:currentfrom
marvin-w:update-xknx-to-15.2

Conversation

@marvin-w
Copy link
Copy Markdown
Contributor

@marvin-w marvin-w commented Oct 18, 2020

Proposed change

Documentation update for underlying library change. See core PR for more details.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase: Update xknx to 0.15.3 core#42026
  • Link to parent pull request in the Brands repository: -
  • This PR fixes or closes issue: -

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 18, 2020
@marvin-w marvin-w force-pushed the update-xknx-to-15.2 branch 2 times, most recently from 5cbef80 to b13048e Compare October 18, 2020 10:57
@marvin-w marvin-w mentioned this pull request Oct 18, 2020
Merged
21 tasks
@marvin-w marvin-w force-pushed the update-xknx-to-15.2 branch 2 times, most recently from 553be4a to 595f0db Compare October 18, 2020 11:06
@marvin-w marvin-w force-pushed the update-xknx-to-15.2 branch from 595f0db to 20d7152 Compare October 18, 2020 12:51
farmio
farmio previously approved these changes Oct 19, 2020
View reviewed changes
Comment thread source/_integrations/knx.markdown Outdated
Comment thread source/_integrations/knx.markdown Outdated
@marvin-w @farmio
Apply suggestions from code review
e5ba29e 
Co-authored-by: Matthias Alphart <farmio@alphart.net>
frenck
frenck previously approved these changes Oct 19, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR new-feature This PR adds documentation for a new Home Assistant feature to an existing integration labels Oct 19, 2020
@marvin-w marvin-w changed the title Update xknx to 0.15.2 Update xknx to 0.15.3 Nov 6, 2020
farmio
farmio requested changes Nov 6, 2020
View reviewed changes
Comment thread source/_integrations/knx.markdown Outdated
Comment thread source/_integrations/knx.markdown
@marvin-w @farmio
Apply suggestions from code review
8552fad 
Co-authored-by: Matthias Alphart <farmio@alphart.net>
farmio
farmio approved these changes Nov 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@farmio farmio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

farmio
farmio requested changes Nov 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@farmio farmio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add documentation for invert from 0.15.3

Comment thread source/_integrations/knx.markdown
Comment thread source/_integrations/knx.markdown
farmio
farmio requested changes Nov 6, 2020
View reviewed changes
Comment thread source/_integrations/knx.markdown Outdated
@marvin-w @farmio
Apply suggestions from code review
658a0ab 
Co-authored-by: Matthias Alphart <farmio@alphart.net>
farmio
farmio previously approved these changes Nov 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@farmio farmio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 now for real 🤣

@a005
Copy link
Copy Markdown

a005 commented Nov 19, 2020

This PR should be merged for 0.118 release! It describes breaking change.

@frenck frenck added the parent-merged The parent PR has been merged already label Nov 19, 2020
@frenck frenck changed the base branch from next to current November 19, 2020 06:52
@frenck frenck dismissed farmio’s stale review November 19, 2020 06:52

The base branch was changed.

@probot-home-assistant probot-home-assistant Bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Nov 19, 2020
@probot-home-assistant probot-home-assistant Bot added current This PR goes into the current branch and removed next This PR goes into the next branch labels Nov 19, 2020
@frenck
Copy link
Copy Markdown
Member

frenck commented Nov 19, 2020

This PR is missed when creating the 0.118 release. Changed the target branch of this PR to current so it ends up in the current documentation of 0.118.

frenck
frenck approved these changes Nov 19, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks! 👍

@frenck frenck merged commit 9099d7d into home-assistant:current Nov 19, 2020
@probot-home-assistant probot-home-assistant Bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Nov 19, 2020
javicalle pushed a commit to javicalle/home-assistant.io that referenced this pull request Nov 21, 2020
@marvin-w @farmio @javicalle
Update xknx to 0.15.3 (home-assistant#15301)
8485685 
Co-authored-by: Matthias Alphart <farmio@alphart.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frenck frenck frenck approved these changes

@farmio farmio farmio left review comments

Assignees

@frenck frenck

Labels

current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! hacktoberfest-accepted has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marvin-w @a005 @frenck @farmio