Add support for learning RF commands with Broadlink remotes#39671
Merged
springstan merged 4 commits intohome-assistant:devfrom Nov 12, 2020
Merged
Add support for learning RF commands with Broadlink remotes#39671springstan merged 4 commits intohome-assistant:devfrom
springstan merged 4 commits intohome-assistant:devfrom
Conversation
|
Hey there @Danielhiversen, mind taking a look at this pull request as its been labeled with an integration ( |
felipediel
commented
Sep 5, 2020
31207f4 to
083c64f
Compare
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
083c64f to
b5ea72b
Compare
b5ea72b to
6c4558a
Compare
elupus
reviewed
Nov 7, 2020
elupus
approved these changes
Nov 7, 2020
Contributor
elupus
left a comment
There was a problem hiding this comment.
I think this looks alright
springstan
reviewed
Nov 10, 2020
Member
springstan
left a comment
There was a problem hiding this comment.
Just some small comments ✌️
Contributor
Author
|
It's better now. Thanks, guys. |
KJonline
pushed a commit
to Pyhass/core
that referenced
this pull request
Nov 13, 2020
* 'dev' of https://github.com/home-assistant/core: (32 commits) Disable parsing scientific/complex number notation in template type (home-assistant#43170) Remove relative time sensor from cert_expiry (home-assistant#42338) Further improve MFI tests (home-assistant#43167) Update translations Guard against empty ssdp locations (home-assistant#43156) Fix playing of Spotify URIs on Sonos (home-assistant#43154) Add missing 'hassio' translation string (home-assistant#43127) Streamline SimpliSafe errors (home-assistant#43117) Update xknx to 0.15.3 (home-assistant#42026) Fix beat calculation (home-assistant#43142) Mock time_date sensor tests (home-assistant#43141) [ci skip] Translation update Fix bug preventing Notion entities from updating their bridge (home-assistant#43122) Bump hass-nabucasa to 0.37.2 (home-assistant#43146) Shelly: minor improvements (home-assistant#43138) Add support for learning RF commands with Broadlink remotes (home-assistant#39671) Fix incorrect Notion battery state calculation (home-assistant#43108) Bump hatasmota to 0.0.30 (home-assistant#43140) Add VSCode debug launch conf (home-assistant#43130) Revert "shelly_naming" rebase errors (home-assistant#43134) ...
rccoleman
pushed a commit
to rccoleman/core
that referenced
this pull request
Dec 4, 2020
…istant#39671) * Add support for learning RF codes with Broadlink remotes * Rename INFRARED and RADIOFREQUENCY to COMMAND_TYPE_IR and COMMAND_TYPE_RF * Rewrite if expression as normal if statement * Use COMMAND_TYPE_IR directly and improve error messages
rccoleman
pushed a commit
to rccoleman/core
that referenced
this pull request
Dec 4, 2020
…istant#39671) * Add support for learning RF codes with Broadlink remotes * Rename INFRARED and RADIOFREQUENCY to COMMAND_TYPE_IR and COMMAND_TYPE_RF * Rewrite if expression as normal if statement * Use COMMAND_TYPE_IR directly and improve error messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds support for learning RF commands with Broadlink devices. These are the proposed changes:
command_type: rfinremote.learn_commandservice.remote.learn_commandwithcommand_type: ir.Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: