Conversation
probot-home-assistant
Bot
added
code-quality
small-pr
Contributor
|
One idea. Maybe allow use env files to set additional arguments? Not sure it matters, the user can set alternative workspace launch config anyway. |
Contributor
|
Our json check seem a bit trigger happy :) |
Member
Author
|
Let's focus on the basic functionality. |
ludeeus
approved these changes
Nov 12, 2020
KJonline
pushed a commit
to Pyhass/core
that referenced
this pull request
Nov 13, 2020
* 'dev' of https://github.com/home-assistant/core: (32 commits) Disable parsing scientific/complex number notation in template type (home-assistant#43170) Remove relative time sensor from cert_expiry (home-assistant#42338) Further improve MFI tests (home-assistant#43167) Update translations Guard against empty ssdp locations (home-assistant#43156) Fix playing of Spotify URIs on Sonos (home-assistant#43154) Add missing 'hassio' translation string (home-assistant#43127) Streamline SimpliSafe errors (home-assistant#43117) Update xknx to 0.15.3 (home-assistant#42026) Fix beat calculation (home-assistant#43142) Mock time_date sensor tests (home-assistant#43141) [ci skip] Translation update Fix bug preventing Notion entities from updating their bridge (home-assistant#43122) Bump hass-nabucasa to 0.37.2 (home-assistant#43146) Shelly: minor improvements (home-assistant#43138) Add support for learning RF commands with Broadlink remotes (home-assistant#39671) Fix incorrect Notion battery state calculation (home-assistant#43108) Bump hatasmota to 0.0.30 (home-assistant#43140) Add VSCode debug launch conf (home-assistant#43130) Revert "shelly_naming" rebase errors (home-assistant#43134) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add VSCode config to launch hass with debugger attached and configure pytest.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: